Re: [PATCHv2 5/5] gdb: implement missing debug handler hook for Python

[Tom de Vries <tdevries@suse.de>]

On 11/16/23 11:59, Andrew Burgess wrote:
> Tom de Vries <tdevries@suse.de> writes:
> 
>> On 11/8/23 16:48, Andrew Burgess wrote:
>>> + for ch in name: + if not ch.isascii() or not (ch.isalnum() or ch in
>>> "_-"): + raise ValueError("invalid character '%s' in handler name: %s" %
>>> (ch, name)) + +
>>
>> on openSUSE leap 15.4 with python 3.6 I run into:
>> ...
>> (gdb) PASS: gdb.python/py-missing-debug.exp: initial checks: debug info
>> no longer found
>> source
>> /data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.python/py-missing-debug/py-missing-debug.py^M
>> Traceback (most recent call last):^M
>>     File
>> "/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.python/py-missing-debug/py-missing-debug.py",
>> line 117, in <module>^M
>>       rhandler = exception_handler()^M
>>     File
>> "/data/vries/gdb/leap-15-4/build/gdb/testsuite/outputs/gdb.python/py-missing-debug/py-missing-debug.py",
>> line 93, in __init__^M
>>       super().__init__("exception_handler")^M
>>     File
>> "/data/vries/gdb/leap-15-4/build/gdb/data-directory/python/gdb/missing_debug.py",
>> line 70, in __init__^M
>>       _validate_name(name)^M
>>     File
>> "/data/vries/gdb/leap-15-4/build/gdb/data-directory/python/gdb/missing_debug.py",
>> line 41, in _validate_name^M
>>       if not ch.isascii() or not (ch.isalnum() or ch in "_-"):^M
>> AttributeError: 'str' object has no attribute 'isascii'^M
>> (gdb) FAIL: gdb.python/py-missing-debug.exp: source python script
> 
> Sorry about this Tom.  Turns out str.isascii() (and friends) were only
> added in 3.7.
> 

Np, thanks for fixing this.

> I believe the patch below should fix things.  Local testing here with
> 3.6 suggests it is fine.  I'll push this tomorrow if I don't get any
> feedback before then.

With this patch the test-case passes cleanly for me:
...
Running 
/data/vries/gdb/src/gdb/testsuite/gdb.python/py-missing-debug.exp ...

		=== gdb Summary ===

# of expected passes		83
...
so, LGTM.

Thanks,
- Tom

> 
> Thanks,
> Andrew
> 
> ---
> 
> commit 32ce7ac847349d2aa15e51878119a4e9df4c331f
> Author: Andrew Burgess <aburgess@redhat.com>
> Date:   Thu Nov 16 10:53:34 2023 +0000
> 
>      gdb/python: remove use of str.isascii()
>      
>      This commit:
>      
>        commit 8f6c452b5a4e50fbb55ff1d13328b392ad1fd416
>        Date:   Sun Oct 15 22:48:42 2023 +0100
>      
>            gdb: implement missing debug handler hook for Python
>      
>      introduced a use of str.isascii(), which was only added in Python 3.7.
>      
>      This commit switches to use curses.ascii.isascii(), as this was
>      available in 3.6.
>      
>      The same is true for str.isalnum(), which is replaced with
>      curses.ascii.isalnum().
>      
>      There should be no user visible changes after this commit.
> 
> diff --git a/gdb/python/lib/gdb/missing_debug.py b/gdb/python/lib/gdb/missing_debug.py
> index 42d69858f96..bb233a66c73 100644
> --- a/gdb/python/lib/gdb/missing_debug.py
> +++ b/gdb/python/lib/gdb/missing_debug.py
> @@ -18,6 +18,7 @@ MissingDebugHandler base class, and register_handler function.
>   """
>   
>   import gdb
> +from curses.ascii import isascii, isalnum
>   
>   
>   def _validate_name(name):
> @@ -38,7 +39,7 @@ def _validate_name(name):
>                       name.
>       """
>       for ch in name:
> -        if not ch.isascii() or not (ch.isalnum() or ch in "_-"):
> +        if not isascii(ch) or not (isalnum(ch) or ch in "_-"):
>               raise ValueError("invalid character '%s' in handler name: %s" % (ch, name))
>   
>   
>