From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] gdb: refactor objfile::find_and_add_separate_symbol_file
Date: Fri, 20 Oct 2023 11:50:09 -0600 [thread overview]
Message-ID: <877cnhp4j2.fsf@tromey.com> (raw)
In-Reply-To: <108c51107d11eae41fd77d54d73613569875c4c7.1697626088.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 18 Oct 2023 11:53:21 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> This is purely a refactoring commit.
Andrew> This commit splits objfile::find_and_add_separate_symbol_file into
Andrew> some separate helper functions. My hope is that the steps for looking
Andrew> up separate debug information are now clearer.
Andrew> In a later commit I'm going to extend
Andrew> objfile::find_and_add_separate_symbol_file, with some additional
Andrew> logic, so starting with a simpler function will make the following
Andrew> changes easier.
Andrew> There should be no user visible changes after this commit.
Andrew> +static std::pair<gdb_bfd_ref_ptr, std::string>
Andrew> +simple_find_and_open_separate_symbol_file
...
Andrew> + result = simple_find_and_open_separate_symbol_file
Andrew> + (this, find_separate_debug_file_by_buildid, &warnings);
...
Andrew> + if (result.first == nullptr)
If this happens to go in after the C++17 series, this code could be
cleaned up a little using structured bindings.
Tom
next prev parent reply other threads:[~2023-10-20 17:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 10:53 [PATCH 0/5] New Python hook for missing debug information Andrew Burgess
2023-10-18 10:53 ` [PATCH 1/5] gdb/coffread: bring separate debug file logic into line with elfread.c Andrew Burgess
2023-10-20 17:35 ` Tom Tromey
2023-10-24 11:59 ` Andrew Burgess
2023-10-18 10:53 ` [PATCH 2/5] gdb: merge debug symbol file lookup code from coffread & elfread paths Andrew Burgess
2023-10-18 13:18 ` Jon Turney
2023-10-18 17:25 ` Andrew Burgess
2023-10-18 10:53 ` [PATCH 3/5] gdb: refactor objfile::find_and_add_separate_symbol_file Andrew Burgess
2023-10-20 17:50 ` Tom Tromey [this message]
2023-10-24 12:03 ` Andrew Burgess
2023-11-08 15:22 ` Andrew Burgess
2023-10-18 10:53 ` [PATCH 4/5] gdb: add an extension language hook for missing debug info Andrew Burgess
2023-10-18 10:53 ` [PATCH 5/5] gdb: implement missing debug handler hook for Python Andrew Burgess
2023-10-18 12:08 ` Eli Zaretskii
2023-11-08 15:48 ` [PATCHv2 0/5] New Python hook for missing debug information Andrew Burgess
2023-11-08 15:48 ` [PATCHv2 1/5] gdb/coffread: bring separate debug file logic into line with elfread.c Andrew Burgess
2023-11-08 15:48 ` [PATCHv2 2/5] gdb: merge debug symbol file lookup code from coffread & elfread paths Andrew Burgess
2023-11-08 15:48 ` [PATCHv2 3/5] gdb: refactor objfile::find_and_add_separate_symbol_file Andrew Burgess
2023-11-08 15:48 ` [PATCHv2 4/5] gdb: add an extension language hook for missing debug info Andrew Burgess
2023-11-08 15:48 ` [PATCHv2 5/5] gdb: implement missing debug handler hook for Python Andrew Burgess
2023-11-12 22:38 ` Tom Tromey
2023-11-15 12:36 ` Tom de Vries
2023-11-16 10:59 ` Andrew Burgess
2023-11-16 11:16 ` Tom de Vries
2023-11-16 17:21 ` Andrew Burgess
2023-11-16 15:26 ` Tom Tromey
2023-11-12 22:39 ` [PATCHv2 0/5] New Python hook for missing debug information Tom Tromey
2023-11-13 16:04 ` Andrew Burgess
2023-11-13 17:18 ` Tom Tromey
2023-11-12 22:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cnhp4j2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).