public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [pushed] Add overrides, fix FreeBSD build
@ 2018-06-27 14:55 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2018-06-27 14:55 UTC (permalink / raw)
  To: gdb-patches; +Cc: Simon Marchi

Fix this:

  CXX    fbsd-nat.o
In file included from fbsd-nat.c:44:
./fbsd-nat.h:40:7: error: 'find_memory_regions' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  int find_memory_regions (find_memory_region_ftype func, void *data);
      ^
./target.h:702:17: note: overridden virtual function is here
    virtual int find_memory_regions (find_memory_region_ftype func, void *data)
                ^
In file included from fbsd-nat.c:44:
./fbsd-nat.h:42:8: error: 'info_proc' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  bool info_proc (const char *, enum info_proc_what);
       ^
./target.h:950:18: note: overridden virtual function is here
    virtual bool info_proc (const char *, enum info_proc_what);
                 ^

gdb/ChangeLog:

	* fbsd-nat.h (class fbsd_nat_target) <find_memory_regions>: Add
	override.
	<info_proc>: Likewise.
---
 gdb/ChangeLog  | 6 ++++++
 gdb/fbsd-nat.h | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d4ae16c..c315246 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2018-06-27  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* fbsd-nat.h (class fbsd_nat_target) <find_memory_regions>: Add
+	override.
+	<info_proc>: Likewise.
+
 2018-06-26  Joel Brobecker  <brobecker@adacore.com>
 
 	* windows-nat.c (do_windows_fetch_inferior_registers): Rename
diff --git a/gdb/fbsd-nat.h b/gdb/fbsd-nat.h
index 8c90dd0..3e34600 100644
--- a/gdb/fbsd-nat.h
+++ b/gdb/fbsd-nat.h
@@ -37,9 +37,9 @@ class fbsd_nat_target : public inf_ptrace_target
 public:
   char *pid_to_exec_file (int pid) override;
 
-  int find_memory_regions (find_memory_region_ftype func, void *data);
+  int find_memory_regions (find_memory_region_ftype func, void *data) override;
 
-  bool info_proc (const char *, enum info_proc_what);
+  bool info_proc (const char *, enum info_proc_what) override;
 
 #ifdef KERN_PROC_AUXV
   enum target_xfer_status xfer_partial (enum target_object object,
-- 
2.7.4

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-06-27 14:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 14:55 [pushed] Add overrides, fix FreeBSD build Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).