Re: [PATCH] gdbsupport: add support for references to checked_static_cast

[Simon Marchi <simon.marchi@efficios.com>]

On 5/19/23 17:31, Kevin Buettner wrote:
> On Thu, 18 May 2023 16:57:37 -0400
> Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> wrote:
> 
>> Add a checked_static_cast overload that works with references.  A bad
>> dynamic cast with references throws std::bad_cast, it would be possible
>> to implement the new overload based on that, but it seemed simpler to
>> just piggy back off the existing function.
>>
>> I found some potential uses of this new overload in amd-dbgapi-target.c,
>> update them to illustrate the use of the new overload.  To build
>> amd-dbgapi-target.c, on needs the amd-dbgapi library, which I don't
>> expect many people to have.  But I have it, and it builds fine here.  I
>> did test the new overload by making a purposely bad cast and it did
>> catch it.
> 
> I'm not especially knowledgeable in this area, but it LGTM.
> 
> Acked-by: Kevin Buettner <kevinb@redhat.com>

Thanks, I'll add your Acked-By.  I'll wait to see if Andrew has anything
to say about it, since he wrote the original feature.

Simon