Re: [PATCH] gdbsupport: add support for references to checked_static_cast

[Simon Marchi <simon.marchi@efficios.com>]

On 5/24/23 14:04, Andrew Burgess wrote:
> Simon Marchi <simon.marchi@efficios.com> writes:
> 
>> On 5/24/23 09:07, Andrew Burgess wrote:
>>> Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>>>
>>>> Add a checked_static_cast overload that works with references.  A bad
>>>> dynamic cast with references throws std::bad_cast, it would be possible
>>>> to implement the new overload based on that, but it seemed simpler to
>>>> just piggy back off the existing function.
>>>>
>>>> I found some potential uses of this new overload in amd-dbgapi-target.c,
>>>> update them to illustrate the use of the new overload.  To build
>>>> amd-dbgapi-target.c, on needs the amd-dbgapi library, which I don't
>>>> expect many people to have.  But I have it, and it builds fine here.  I
>>>> did test the new overload by making a purposely bad cast and it did
>>>> catch it.
>>>
>>> Looks great.  Thanks for expanding this feature.
>>>
>>> Reviewed-By: Andrew Burgess <aburgess@redhat.com>
>>
>> Thanks.  Are you also fine with the switch to use
>> gdb::Requires<std::is_reference<T> to do the "target is reference"
>> check, as Lancelot suggested?
> 
> Yes, that looks good too.

Thanks, pushed.

Simon