* [PATCH v4 1/2] gdb: testsuite: print explicit test result in can_spawn_for_attach()
2022-02-22 12:42 [PATCH v4 0/2] Modify can_spawn_for_attach Tiezhu Yang
@ 2022-02-22 12:42 ` Tiezhu Yang
2022-02-22 14:42 ` Simon Marchi
2022-02-22 12:42 ` [PATCH v4 2/2] gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp Tiezhu Yang
1 sibling, 1 reply; 4+ messages in thread
From: Tiezhu Yang @ 2022-02-22 12:42 UTC (permalink / raw)
To: gdb-patches
In the current code, there is no test result when execute the following
commands:
$ make check-gdb TESTS="gdb.base/attach-pie-noexec.exp" RUNTESTFLAGS="--target_board=remote-gdbserver-on-localhost"
$ make check-gdb TESTS="gdb.base/attach-pie-noexec.exp" RUNTESTFLAGS="--target_board=native-gdbserver"
It is better to print explicit test result in can_spawn_for_attach().
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
gdb/testsuite/lib/gdb.exp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index a3717a4..d15ab90 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5063,6 +5063,7 @@ proc can_spawn_for_attach { } {
# back the pid of the program. On remote boards, that would give
# us instead the PID of e.g., the ssh client, etc.
if [is_remote target] then {
+ untested "skipping tests due to is_remote target"
return 0
}
@@ -5070,6 +5071,7 @@ proc can_spawn_for_attach { } {
# stub-like, where GDB finds the program already started on
# initial connection.
if {[target_info exists use_gdb_stub]} {
+ untested "skipping tests due to use_gdb_stub"
return 0
}
--
2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v4 2/2] gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp
2022-02-22 12:42 [PATCH v4 0/2] Modify can_spawn_for_attach Tiezhu Yang
2022-02-22 12:42 ` [PATCH v4 1/2] gdb: testsuite: print explicit test result in can_spawn_for_attach() Tiezhu Yang
@ 2022-02-22 12:42 ` Tiezhu Yang
1 sibling, 0 replies; 4+ messages in thread
From: Tiezhu Yang @ 2022-02-22 12:42 UTC (permalink / raw)
To: gdb-patches
If /proc/sys/kernel/yama/ptrace_scope is 1, when execute the test case
gdb.base/attach-pie-noexec.exp without superuser, the gdb.log shows the
following info:
(gdb) attach 6500
Attaching to process 6500
ptrace: Operation not permitted.
(gdb) PASS: gdb.base/attach-pie-noexec.exp: attach
It is obviously wrong, the expected result should be UNSUPPORTED in such
a case.
It is better to make can_spawn_for_attach to return false for this case.
It would have to setup a small test program, compile it to exec, spawn it
and try to attach to it.
With this patch, we can see "Operation not permitted" in the log info,
and then we can do the following processes to test:
(1) set ptrace_scope as 0
$ echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope
$ make check-gdb TESTS="gdb.base/attach-pie-noexec.exp"
(2) use sudo
$ sudo make check-gdb TESTS="gdb.base/attach-pie-noexec.exp"
Additionally, handle the other cases when test with RUNTESTFLAGS=
"--target_board=native-extended-gdbserver".
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
gdb/testsuite/lib/gdb.exp | 44 +++++++++++++++++++++++++++++++++++++-------
1 file changed, 37 insertions(+), 7 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index d15ab90..b9e5596 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5058,7 +5058,7 @@ proc gdb_exit { } {
# Return true if we can spawn a program on the target and attach to
# it.
-proc can_spawn_for_attach { } {
+gdb_caching_proc can_spawn_for_attach {
# We use exp_pid to get the inferior's pid, assuming that gives
# back the pid of the program. On remote boards, that would give
# us instead the PID of e.g., the ssh client, etc.
@@ -5075,6 +5075,42 @@ proc can_spawn_for_attach { } {
return 0
}
+ set me "can_spawn_for_attach"
+ set src { int main (void) { sleep (600); return 0; } }
+ if {![gdb_simple_compile $me $src executable]} {
+ return 0
+ }
+
+ set test_spawn_id [spawn_wait_for_attach $obj]
+ set test_pid [spawn_id_get_pid $test_spawn_id]
+
+ gdb_start
+ file delete $obj
+ gdb_test_multiple "attach $test_pid" "can spawn for attach" {
+ -re -wrap "Attaching to process $test_pid\r\n.*No executable file now.*" {
+ pass $gdb_test_name
+ kill_wait_spawned_process $test_spawn_id
+ return 1
+ }
+ -re -wrap "Attaching to process $test_pid\r\n.*ptrace: Operation not permitted\\." {
+ unsupported "$gdb_test_name (Operation not permitted)"
+ kill_wait_spawned_process $test_spawn_id
+ return 0
+ }
+ -re -wrap "Attaching to process $test_pid\r\n.*Attaching to process $test_pid failed" {
+ unsupported "$gdb_test_name (Attaching to process failed)"
+ kill_wait_spawned_process $test_spawn_id
+ return 0
+ }
+ -re -wrap "Attaching to process $test_pid\r\n.*XML support was disabled at compile time.*" {
+ pass $gdb_test_name
+ kill_wait_spawned_process $test_spawn_id
+ return 1
+ }
+ }
+
+ kill_wait_spawned_process $test_spawn_id
+
# Assume yes.
return 1
}
@@ -5124,12 +5160,6 @@ proc spawn_id_get_pid { spawn_id } {
proc spawn_wait_for_attach { executable_list } {
set spawn_id_list {}
- if ![can_spawn_for_attach] {
- # The caller should have checked can_spawn_for_attach itself
- # before getting here.
- error "can't spawn for attach with this target/board"
- }
-
foreach {executable} $executable_list {
# Note we use Expect's spawn, not Tcl's exec, because with
# spawn we control when to wait for/reap the process. That
--
2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread