[PATCH] gdb: Remove duplicate "gdb Summary" in the test output

[PATCH] gdb: Remove duplicate "gdb Summary" in the test output

[Tiezhu Yang]

There exists duplicate "gdb Summary" in the test output, just modify
gdb/testsuite/Makefile.in to remove the redundant info.

Here is an example, when execute the following command:

  make check-gdb TESTS="gdb.base/a2-run.exp"

we can see the following info in the output:

  Running /home/loongson/gdb.git/gdb/testsuite/gdb.base/a2-run.exp ...

          === gdb Summary ===

  # of expected passes        9
  /home/loongson/build.git/gdb/gdb version  13.0.50.20220625-git ...

          === gdb Summary ===

  # of expected passes        9
  /home/loongson/build.git/gdb/gdb version  13.0.50.20220625-git ...

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 gdb/testsuite/Makefile.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index 87ba522..aa0c00f 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -212,7 +212,6 @@ check-single:
 	$(DO_RUNTEST) $(RUNTESTFLAGS) $(expanded_tests_or_none) $(TIMESTAMP); \
 	result=$$?; \
 	$(SHELL) $(srcdir)/lib/dg-add-core-file-count.sh; \
-	sed -n '/=== gdb Summary ===/,$$ p' gdb.sum; \
 	exit $$result
 
 check-single-racy:
-- 
2.1.0

Re: [PATCH] gdb: Remove duplicate "gdb Summary" in the test output

[Tom Tromey]

>>>>> Tiezhu Yang <yangtiezhu@loongson.cn> writes:

> There exists duplicate "gdb Summary" in the test output, just modify
> gdb/testsuite/Makefile.in to remove the redundant info.
> Here is an example, when execute the following command:
>   make check-gdb TESTS="gdb.base/a2-run.exp"

I think what's happening here is that the "Summary" line is added for
the benefit of parallel "make check".  However, in your case, you're
only running a single test.  But, if you run many tests, I think the
output won't look redundant.  So, I tend to think it should just remain
the way it is.

Tom