Re: [PATCH v2] Fix hardware watchpoints in replay mode

[Hannes Domani <ssbssa@yahoo.de>]

 Am Montag, 20. November 2023, 14:09:34 MEZ hat Guinevere Larsen <blarsen@redhat.com> Folgendes geschrieben:

> On 14/09/2023 18:27, Hannes Domani via Gdb-patches wrote:
> > Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597
> > caused a regression that meant hardware watchpoint stops would not
> > trigger in reverse execution or replay mode.  This was documented in
> > PR breakpoints/21969.
> > The problem is that record_check_stopped_by_breakpoint always overwrites
> > record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT
> > value which would be checked afterwards.
> >
> > This commit fixes that by checking if record_full_stop_reason is
> > TARGET_STOPPED_BY_BREAKPOINT and, if so, not overriding it.
> >
> > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=21969
> > ---
> I have sent a review to this patch. Your spam filter must have catched
> it or something similar. If you can't find it, here's the link for the
> public inbox:
> https://inbox.sourceware.org/gdb-patches/2eb65a2d-aa80-5930-3033-bfd82baa2ed9@redhat.com/

I saw that, but it doesn't really make clear what I should do now.
And from what I can remember of our discussion on IRC, you wanted to wait if Pedro had anything to add.


Regards
Hannes