* [PATCH] [AArch64] Fix gdb.base/msym*.exp failures
@ 2020-10-14 23:01 Luis Machado
2020-10-16 21:52 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Luis Machado @ 2020-10-14 23:01 UTC (permalink / raw)
To: gdb-patches, Alan.Hayward
AArch64 generates functions without a prologue for these two testcases,
therefore we shouldn't expect the function location to be displayed with
an offset.
gdb/testsuite/ChangeLog:
YYYY-MM-DD Luis Machado <luis.machado@linaro.org>
* gdb.base/msym-bp-shl.exp (test_break): Adjust pattern to not
expect an offset from the function.
* gdb.base/msym-bp.exp (test): Likewise.
---
gdb/testsuite/gdb.base/msym-bp-shl.exp | 6 +++---
gdb/testsuite/gdb.base/msym-bp.exp | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/gdb.base/msym-bp-shl.exp b/gdb/testsuite/gdb.base/msym-bp-shl.exp
index fee1d7233f..0d860f9b1f 100644
--- a/gdb/testsuite/gdb.base/msym-bp-shl.exp
+++ b/gdb/testsuite/gdb.base/msym-bp-shl.exp
@@ -72,7 +72,7 @@ proc test {debug} {
} else {
test_info_break_2 \
"<foo@plt.*>" \
- "<foo\\+$decimal>"
+ "<foo(\\+$decimal)?>"
}
}
@@ -96,8 +96,8 @@ proc test {debug} {
"in foo at .*msym-bp-shl-lib.c:$decimal"
} else {
test_info_break_2 \
- "<foo\\+$decimal>" \
- "<foo\\+$decimal>"
+ "<foo(\\+$decimal)?>" \
+ "<foo(\\+$decimal)?>"
}
}
}
diff --git a/gdb/testsuite/gdb.base/msym-bp.exp b/gdb/testsuite/gdb.base/msym-bp.exp
index c4bef7c188..6c39437490 100644
--- a/gdb/testsuite/gdb.base/msym-bp.exp
+++ b/gdb/testsuite/gdb.base/msym-bp.exp
@@ -60,8 +60,8 @@ proc test {debug} {
"in foo at .*msym-bp-2.c:$decimal"
} else {
test_info_break_2 \
- "<foo\\+$decimal>" \
- "<foo\\+$decimal>"
+ "<foo(\\+$decimal)?>" \
+ "<foo(\\+$decimal)?>"
}
}
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [AArch64] Fix gdb.base/msym*.exp failures
2020-10-14 23:01 [PATCH] [AArch64] Fix gdb.base/msym*.exp failures Luis Machado
@ 2020-10-16 21:52 ` Simon Marchi
2020-10-22 14:46 ` Luis Machado
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2020-10-16 21:52 UTC (permalink / raw)
To: Luis Machado, gdb-patches, Alan.Hayward
On 2020-10-14 7:01 p.m., Luis Machado via Gdb-patches wrote:
> AArch64 generates functions without a prologue for these two testcases,
> therefore we shouldn't expect the function location to be displayed with
> an offset.
LGTM, thanks.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [AArch64] Fix gdb.base/msym*.exp failures
2020-10-16 21:52 ` Simon Marchi
@ 2020-10-22 14:46 ` Luis Machado
0 siblings, 0 replies; 3+ messages in thread
From: Luis Machado @ 2020-10-22 14:46 UTC (permalink / raw)
To: Simon Marchi, gdb-patches, Alan.Hayward
On 10/16/20 6:52 PM, Simon Marchi wrote:
> On 2020-10-14 7:01 p.m., Luis Machado via Gdb-patches wrote:
>> AArch64 generates functions without a prologue for these two testcases,
>> therefore we shouldn't expect the function location to be displayed with
>> an offset.
>
> LGTM, thanks.
>
> Simon
>
Thanks Simon. Pushed now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-22 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 23:01 [PATCH] [AArch64] Fix gdb.base/msym*.exp failures Luis Machado
2020-10-16 21:52 ` Simon Marchi
2020-10-22 14:46 ` Luis Machado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).