Re: [PATCH 1/4] Use gdb::checked_static_cast for watchpoints

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2023-09-15 14:36, Tom Tromey via Gdb-patches wrote:
> This replaces some casts to 'watchpoint *' with checked_static_cast.
> In one spot, an unnecessary block is also removed.
> ---
>  gdb/breakpoint.c           | 298 +++++++++++++++++++++++----------------------
>  gdb/guile/scm-breakpoint.c |   2 +-
>  gdb/python/py-breakpoint.c |   2 +-
>  3 files changed, 153 insertions(+), 149 deletions(-)
> 
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index c429af455ff..c0d86f38c73 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -5249,7 +5249,7 @@ watchpoint_check (bpstat *bs)
>  
>    /* BS is built from an existing struct breakpoint.  */
>    gdb_assert (bs->breakpoint_at != NULL);
> -  b = (struct watchpoint *) bs->breakpoint_at;
> +  b = gdb::checked_static_cast<struct watchpoint *> (bs->breakpoint_at);

Not mandatory, but when doing these refactorings, I find it's a good
time to bring the variable declaration down.  And also, get rid of the
struct keyword, if possible.  So:

  watchpoint *b = gdb::checked_static_cast<watchpoint *> (bs->breakpoint_at);

Simon