From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Use gdb::checked_static_cast for watchpoints
Date: Mon, 18 Sep 2023 08:20:38 -0600 [thread overview]
Message-ID: <87h6nra7gp.fsf@tromey.com> (raw)
In-Reply-To: <1aba9929-690e-448d-b7d7-5cf90604fdad@polymtl.ca> (Simon Marchi's message of "Sun, 17 Sep 2023 20:40:33 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Not mandatory, but when doing these refactorings, I find it's a good
Simon> time to bring the variable declaration down. And also, get rid of the
Simon> struct keyword, if possible. So:
Simon> watchpoint *b = gdb::checked_static_cast<watchpoint *> (bs->breakpoint_at);
I made these changes in v2.
Tom
next prev parent reply other threads:[~2023-09-18 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 18:36 [PATCH 0/4] Use checked_static_cast for breakpoint casts Tom Tromey
2023-09-15 18:36 ` [PATCH 1/4] Use gdb::checked_static_cast for watchpoints Tom Tromey
2023-09-18 0:40 ` Simon Marchi
2023-09-18 14:20 ` Tom Tromey [this message]
2023-09-15 18:36 ` [PATCH 2/4] Use gdb::checked_static_cast for tracepoints Tom Tromey
2023-09-15 18:36 ` [PATCH 3/4] Use gdb::checked_static_cast for code_breakpoint Tom Tromey
2023-09-15 18:36 ` [PATCH 4/4] Use gdb::checked_static_cast for catchpoints Tom Tromey
2023-09-18 0:45 ` [PATCH 0/4] Use checked_static_cast for breakpoint casts Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6nra7gp.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).