Re: [PATCH RESEND] gdb: remove static buffer in command_line_input

[Pedro Alves <pedro@palves.net>]

On 2022-12-15 7:06 p.m., Simon Marchi via Gdb-patches wrote:
>    else
>      {
>        /* Copy whole line including terminating null, and we're
>  	 done.  */
> -      buffer_grow (cmd_line_buffer, rl, len + 1);
> -      cmd = cmd_line_buffer->buffer;
> +      cmd_line_buffer.append (rl, len + 1);
> +      return true;

std::string is guaranteed to be null terminated, but, it can also hold
\0 characters in the middle of the string.  Isn't that

  cmd_line_buffer.append (rl, len + 1);

ending up with an embedded \0 at the end of the string, with cmd_line_buffer.size() accounting for it?



>      }