Re: [PATCH RESEND] gdb: remove static buffer in command_line_input

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> [I sent this earlier today, but I don't see it in the archives.
Simon> Resending it through a different computer / SMTP.]

I didn't see it either.

Simon> Fix that by removing the static buffer.

Wow, I've wanted to remove 'struct buffer' for a while now, this is a
big step toward that.

Simon> So, it started with modifying command_line_input as described above, all
Simon> the other changes derive directly from that.

It's hard to review / understand a change like this but it seems ok to
me, as far as I can tell.

Simon> One slightly shady thing is in handle_line_of_input, where we now pass a
Simon> pointer to an std::string's internal buffer to readline's history_value
Simon> function, which takes a `char *`.  I'm pretty sure that this function
Simon> does not modify the input string, because I was able to change it (with
Simon> enough massaging) to take a `const char *`.

I think sending a note to upstream readline would be good.

thanks,
Tom