public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH] [testsuite] gdb.base/dlmopen: Fix test name and use gdb_attach
Date: Fri, 4 Nov 2022 16:13:51 +0000	[thread overview]
Message-ID: <1f0bec9f-1c88-8fc8-1ea8-14b4c41a163f@amd.com> (raw)
In-Reply-To: <6dab4cb2-c1d5-35d3-a295-9c8a5b4927d8@simark.ca>

Hi,

Thanks for the review.

> 
> I would prefer doing an early return:
> 
> if { ![gdb_attach $testpid] } {
>      return
> }
> 
> ... just because it keeps the following code at the original column.

I'll change this and push the patch shortly.

> But regardless:
> 
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
> 
> Simon

Best,
Lancelot.

      reply	other threads:[~2022-11-04 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 15:57 Lancelot SIX
2022-11-04 16:10 ` Simon Marchi
2022-11-04 16:13   ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f0bec9f-1c88-8fc8-1ea8-14b4c41a163f@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).