regressions in gdb.btrace with 2a8339b71f37f2d02f5b2194929c9d702ef27223

regressions in gdb.btrace with 2a8339b71f37f2d02f5b2194929c9d702ef27223

[Metzger, Markus T]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

Hello Carl,

Commit 2a8339b71f37f2d02f5b2194929c9d702ef27223 causes regressions in gdb.btrace:

FAIL: gdb.btrace/step.exp: replay: reverse-finish.1
FAIL: gdb.btrace/step.exp: replay: reverse-next.2
FAIL: gdb.btrace/step.exp: replay: reverse-finish.2 (GDB internal error)
FAIL: gdb.btrace/tailcall-only.exp: reverse-step
FAIL: gdb.btrace/tailcall-only.exp: up
FAIL: gdb.btrace/tailcall.exp: reverse-finish.1
FAIL: gdb.btrace/tailcall.exp: reverse-step.2
FAIL: gdb.btrace/tailcall.exp: next.1
FAIL: gdb.btrace/tailcall.exp: reverse-next.1
FAIL: gdb.btrace/tailcall.exp: step.1
FAIL: gdb.btrace/tailcall.exp: finish.2
FAIL: gdb.btrace/tailcall.exp: reverse-step.3
FAIL: gdb.btrace/tailcall.exp: finish.3

Regards,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: regressions in gdb.btrace with 2a8339b71f37f2d02f5b2194929c9d702ef27223

[Carl Love]

Metzger:

On Tue, 2023-03-21 at 08:13 +0000, Metzger, Markus T wrote:
> This Message Is From an External Sender
> This message came from outside your organization.       
> Hello Carl,
>  
> Commit 2a8339b71f37f2d02f5b2194929c9d702ef27223 causes regressions in
> gdb.btrace:
>  
> FAIL: gdb.btrace/step.exp: replay: reverse-finish.1
> FAIL: gdb.btrace/step.exp: replay: reverse-next.2
> FAIL: gdb.btrace/step.exp: replay: reverse-finish.2 (GDB internal
> error)
> FAIL: gdb.btrace/tailcall-only.exp: reverse-step
> FAIL: gdb.btrace/tailcall-only.exp: up
> FAIL: gdb.btrace/tailcall.exp: reverse-finish.1
> FAIL: gdb.btrace/tailcall.exp: reverse-step.2
> FAIL: gdb.btrace/tailcall.exp: next.1
> FAIL: gdb.btrace/tailcall.exp: reverse-next.1
> FAIL: gdb.btrace/tailcall.exp: step.1
> FAIL: gdb.btrace/tailcall.exp: finish.2
> FAIL: gdb.btrace/tailcall.exp: reverse-step.3
> FAIL: gdb.btrace/tailcall.exp: finish.3
>  
Please see the fix posted in 

https://sourceware.org/pipermail/gdb-patches/2023-March/198139.html

Let me know if that fixes the issues you are seeing.

                   Carl 

RE: regressions in gdb.btrace with 2a8339b71f37f2d02f5b2194929c9d702ef27223

[Metzger, Markus T]

Thanks, Carl,

>Please see the fix posted in
>
>https://sourceware.org/pipermail/gdb-patches/2023-March/198139.html
>
>Let me know if that fixes the issues you are seeing.

This fixes the regressions I'm seeing.

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

RE: regressions in gdb.btrace with 2a8339b71f37f2d02f5b2194929c9d702ef27223

[Carl Love]

Markus:

On Tue, 2023-03-21 at 14:47 +0000, Metzger, Markus T wrote:
> Thanks, Carl,
> 
> > Please see the fix posted in
> > 
> > https://sourceware.org/pipermail/gdb-patches/2023-March/198139.html 
> > 
> > Let me know if that fixes the issues you are seeing.
> 
> This fixes the regressions I'm seeing.
> 
> Regards,
> Markus.
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <
> http://www.intel.de
>  >
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> Silva  
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928

I have committed the patch to fix the regressions.
commit 70ea5a46bd926149fb4a9c3da32c2fc14f6e83c3 (HEAD -> master,
origin/master, origin/HEAD)
Author: Carl Love <cel@us.ibm.com>
Date:   Mon Mar 20 16:59:33 2023 -0400

    PowerPC: regression fix for reverse-finish command.
    
    The recent commit:
    
      commit 2a8339b71f37f2d02f5b2194929c9d702ef27223
      Author: Carl Love <cel@us.ibm.com>
      Date:   Thu Mar 9 16:10:18 2023 -0500
    
       PowerPC: fix for gdb.reverse/finish-precsave.exp and
gdb.reverse/finish-reverse.exp
    ...

               Carl