From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix bug in fixed-point handling
Date: Mon, 31 Jul 2023 23:41:12 +0200 [thread overview]
Message-ID: <1f4e795f-32c2-321d-d7f9-62a51437f513@suse.de> (raw)
In-Reply-To: <87zg3cf33d.fsf@tromey.com>
On 7/31/23 18:38, Tom Tromey via Gdb-patches wrote:
>>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> Alexandre Oliva found a bug in gdb's handling of fixed-point -- a
> Tom> certain Ada fixed-point type would be misintepreted. The bug was that
> Tom> the DW_AT_small looked like:
>
> Tom> <1><13cd>: Abbrev Number: 16 (DW_TAG_constant)
> Tom> <13ce> DW_AT_GNU_numerator: 1
> Tom> <13cf> DW_AT_GNU_denominator: 0x8000000000000000
>
> Tom> ... but gdb interpreted the denominator as a negative value.
>
> I'm checking this in.
Test-case fails with gcc-9 and earlier:
...
(gdb) PASS: gdb.ada/fixed_points.exp: scenario=all: print fp4_var / 1
p Float(Another_Fixed) = Float(Another_Delta * 5)^M
No definition of "another_delta" in current context.^M
(gdb) FAIL: gdb.ada/fixed_points.exp: scenario=all: value of another_fixed
...
Thanks,
- Tom
next prev parent reply other threads:[~2023-07-31 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 15:24 Tom Tromey
2023-07-31 16:38 ` Tom Tromey
2023-07-31 21:41 ` Tom de Vries [this message]
2023-08-01 14:35 ` Tom Tromey
2023-08-02 0:02 ` Tom de Vries
2023-08-02 15:10 ` Tom Tromey
2023-08-02 15:25 ` Tom de Vries
2023-08-02 16:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4e795f-32c2-321d-d7f9-62a51437f513@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).