From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tromey@adacore.com>,
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix bug in fixed-point handling
Date: Tue, 01 Aug 2023 08:35:39 -0600 [thread overview]
Message-ID: <87v8dyg79g.fsf@tromey.com> (raw)
In-Reply-To: <1f4e795f-32c2-321d-d7f9-62a51437f513@suse.de> (Tom de Vries's message of "Mon, 31 Jul 2023 23:41:12 +0200")
Tom> Test-case fails with gcc-9 and earlier:
Tom> ...
Tom> (gdb) PASS: gdb.ada/fixed_points.exp: scenario=all: print fp4_var / 1
Tom> p Float(Another_Fixed) = Float(Another_Delta * 5)^M
Tom> No definition of "another_delta" in current context.^M
Tom> (gdb) FAIL: gdb.ada/fixed_points.exp: scenario=all: value of another_fixed
Tom> ...
Did you happen to try with GCC 10?
I'm wondering if the appended is enough or if it should be conditional
on gcc 10 specifically.
Tom
diff --git a/gdb/testsuite/gdb.ada/fixed_points.exp b/gdb/testsuite/gdb.ada/fixed_points.exp
index 2edc63f4071..12f1adfc249 100644
--- a/gdb/testsuite/gdb.ada/fixed_points.exp
+++ b/gdb/testsuite/gdb.ada/fixed_points.exp
@@ -90,8 +90,8 @@ foreach_with_prefix scenario {all minimal} {
# This only started working in GCC 11.
if {$scenario == "minimal" && [test_compiler_info {gcc-11-*}]} {
gdb_test "print fp5_var" " = 3e-19"
- }
- gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \
- "value of another_fixed"
+ gdb_test "p Float(Another_Fixed) = Float(Another_Delta * 5)" "true" \
+ "value of another_fixed"
+ }
}
next prev parent reply other threads:[~2023-08-01 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 15:24 Tom Tromey
2023-07-31 16:38 ` Tom Tromey
2023-07-31 21:41 ` Tom de Vries
2023-08-01 14:35 ` Tom Tromey [this message]
2023-08-02 0:02 ` Tom de Vries
2023-08-02 15:10 ` Tom Tromey
2023-08-02 15:25 ` Tom de Vries
2023-08-02 16:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8dyg79g.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).