public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Use upper case for metasyntactic variables in "help find"
@ 2019-02-14 15:01 Tom Tromey
  2019-02-19 23:54 ` Kevin Buettner
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2019-02-14 15:01 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

While answering a user's question on irc, I realized that the
metasyntactic variables in "help find" are not in upper case.  As you
know this is one of my pet quests, so here is a patch to fix this.
Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-02-14  Tom Tromey  <tromey@adacore.com>

	* findcmd.c (_initialize_mem_search): Use upper case for
	metasyntactic variables.
---
 gdb/ChangeLog | 5 +++++
 gdb/findcmd.c | 6 +++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/gdb/findcmd.c b/gdb/findcmd.c
index cd461003d36..52f8f80aaae 100644
--- a/gdb/findcmd.c
+++ b/gdb/findcmd.c
@@ -286,9 +286,9 @@ _initialize_mem_search (void)
   add_cmd ("find", class_vars, find_command, _("\
 Search memory for a sequence of bytes.\n\
 Usage:\nfind \
-[/size-char] [/max-count] start-address, end-address, expr1 [, expr2 ...]\n\
-find [/size-char] [/max-count] start-address, +length, expr1 [, expr2 ...]\n\
-size-char is one of b,h,w,g for 8,16,32,64 bit values respectively,\n\
+[/SIZE-CHAR] [/MAX-COUNT] START-ADDRESS, END-ADDRESS, EXPR1 [, EXPR2 ...]\n\
+find [/SIZE-CHAR] [/MAX-COUNT] START-ADDRESS, +LENGTH, EXPR1 [, EXPR2 ...]\n\
+SIZE-CHAR is one of b,h,w,g for 8,16,32,64 bit values respectively,\n\
 and if not specified the size is taken from the type of the expression\n\
 in the current language.\n\
 Note that this means for example that in the case of C-like languages\n\
-- 
2.20.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Use upper case for metasyntactic variables in "help find"
  2019-02-14 15:01 [PATCH] Use upper case for metasyntactic variables in "help find" Tom Tromey
@ 2019-02-19 23:54 ` Kevin Buettner
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Buettner @ 2019-02-19 23:54 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

On Thu, 14 Feb 2019 08:01:08 -0700
Tom Tromey <tromey@adacore.com> wrote:

> While answering a user's question on irc, I realized that the
> metasyntactic variables in "help find" are not in upper case.  As you
> know this is one of my pet quests, so here is a patch to fix this.
> Tested on x86-64 Fedora 29.
> 
> gdb/ChangeLog
> 2019-02-14  Tom Tromey  <tromey@adacore.com>
> 
> 	* findcmd.c (_initialize_mem_search): Use upper case for
> 	metasyntactic variables.

LGTM.

Kevin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-19 23:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 15:01 [PATCH] Use upper case for metasyntactic variables in "help find" Tom Tromey
2019-02-19 23:54 ` Kevin Buettner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).