From: Kamil Rytarowski <n54@gmx.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 03/10] Remove unneeded netbsd_add_process()
Date: Fri, 2 Oct 2020 04:17:57 +0200 [thread overview]
Message-ID: <20201002021804.2814-4-n54@gmx.com> (raw)
In-Reply-To: <20201002021804.2814-1-n54@gmx.com>
Currently it does not add any value.
The netbsd_tdesc local variable is no longer needed. Remove it.
The tdesc value is set by the low target now.
gdbserver/ChangeLog:
* netbsd-low.cc (netbsd_tdesc): Remove.
(netbsd_add_process): Likewise.
(netbsd_process_target::create_inferior): Update.
---
gdbserver/ChangeLog | 6 ++++++
gdbserver/netbsd-low.cc | 15 +--------------
2 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index 47714e8f85a..4fa59ae2dad 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,9 @@
+2020-10-01 Kamil Rytarowski <n54@gmx.com>
+
+ * netbsd-low.cc (netbsd_tdesc): Remove.
+ (netbsd_add_process): Likewise.
+ (netbsd_process_target::create_inferior): Update.
+
2020-10-01 Kamil Rytarowski <n54@gmx.com>
* netbsd-low.cc (elf_64_file_p): Turn into...
diff --git a/gdbserver/netbsd-low.cc b/gdbserver/netbsd-low.cc
index b1f2454f755..c2f34bd3339 100644
--- a/gdbserver/netbsd-low.cc
+++ b/gdbserver/netbsd-low.cc
@@ -43,19 +43,6 @@
int using_threads = 1;
-const struct target_desc *netbsd_tdesc;
-
-/* Call add_process with the given parameters, and initialize
- the process' private data. */
-
-static void
-netbsd_add_process (int pid, int attached)
-{
- struct process_info *proc = add_process (pid, attached);
- proc->tdesc = netbsd_tdesc;
- proc->priv = nullptr;
-}
-
/* Implement the create_inferior method of the target_ops vector. */
int
@@ -99,7 +86,7 @@ netbsd_process_target::create_inferior (const char *program,
get_environ ()->envp (), fn,
nullptr, nullptr, nullptr, nullptr);
- netbsd_add_process (pid, 0);
+ add_process (pid, 0);
post_fork_inferior (pid, program);
--
2.28.0
next prev parent reply other threads:[~2020-10-02 2:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 2:17 [PATCH 00/10] Refactor the NetBSD gdbserver support Kamil Rytarowski
2020-10-02 2:17 ` [PATCH 01/10] Merge netbsd_ptrace_fun into the netbsd_process_target class Kamil Rytarowski
2020-10-07 2:37 ` Simon Marchi
2020-10-07 4:36 ` Kamil Rytarowski
2020-10-07 11:19 ` Simon Marchi
2020-10-07 12:27 ` Kamil Rytarowski
2020-10-02 2:17 ` [PATCH 02/10] Include elf_64_file_p in " Kamil Rytarowski
2020-10-07 2:45 ` Simon Marchi
2020-10-02 2:17 ` Kamil Rytarowski [this message]
2020-10-07 2:48 ` [PATCH 03/10] Remove unneeded netbsd_add_process() Simon Marchi
2020-10-02 2:17 ` [PATCH 04/10] Include gdb_catching_syscalls_p in the netbsd_process_target class Kamil Rytarowski
2020-10-07 2:55 ` Simon Marchi
2020-10-02 2:17 ` [PATCH 05/10] Include netbsd_wait " Kamil Rytarowski
2020-10-07 2:58 ` Simon Marchi
2020-10-02 2:18 ` [PATCH 06/10] Include netbsd_waitpid " Kamil Rytarowski
2020-10-02 2:18 ` [PATCH 07/10] Include netbsd_store_waitstatus " Kamil Rytarowski
2020-10-02 2:18 ` [PATCH 08/10] Include netbsd_catch_this_syscall " Kamil Rytarowski
2020-10-07 3:00 ` Simon Marchi
2020-10-02 2:18 ` [PATCH 09/10] Include the functions of qxfer_libraries_svr4 in netbsd_process_target Kamil Rytarowski
2020-10-07 3:02 ` Simon Marchi
2020-10-02 2:18 ` [PATCH 10/10] Fix whitespace formatting Kamil Rytarowski
2020-10-07 3:02 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002021804.2814-4-n54@gmx.com \
--to=n54@gmx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).