From: Simon Marchi <simark@simark.ca>
To: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 02/10] Include elf_64_file_p in the netbsd_process_target class
Date: Tue, 6 Oct 2020 22:45:17 -0400 [thread overview]
Message-ID: <21fccf3d-3b54-426c-0f7b-6087ab2f353e@simark.ca> (raw)
In-Reply-To: <20201002021804.2814-3-n54@gmx.com>
On 2020-10-01 10:17 p.m., Kamil Rytarowski wrote:
> gdbserver/ChangeLog:
>
> * netbsd-low.cc (elf_64_file_p): Turn into...
> (netbsd_process_target::elf_64_file_p): ...this.
> * netbsd-low.h (netbsd_process_target::elf_64_file_p): Add.
I don't see the point in making this a member function. It doesn't
interact with netbsd_process_target class in any way, so low cohesion.
So the net result is that if you need to use this quite generic function
from outside the netbsd_process_target in the future, you can't.
I'm not strongly opposing, since this is not a particularly important
matter, I just find it odd.
Simon
next prev parent reply other threads:[~2020-10-07 2:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 2:17 [PATCH 00/10] Refactor the NetBSD gdbserver support Kamil Rytarowski
2020-10-02 2:17 ` [PATCH 01/10] Merge netbsd_ptrace_fun into the netbsd_process_target class Kamil Rytarowski
2020-10-07 2:37 ` Simon Marchi
2020-10-07 4:36 ` Kamil Rytarowski
2020-10-07 11:19 ` Simon Marchi
2020-10-07 12:27 ` Kamil Rytarowski
2020-10-02 2:17 ` [PATCH 02/10] Include elf_64_file_p in " Kamil Rytarowski
2020-10-07 2:45 ` Simon Marchi [this message]
2020-10-02 2:17 ` [PATCH 03/10] Remove unneeded netbsd_add_process() Kamil Rytarowski
2020-10-07 2:48 ` Simon Marchi
2020-10-02 2:17 ` [PATCH 04/10] Include gdb_catching_syscalls_p in the netbsd_process_target class Kamil Rytarowski
2020-10-07 2:55 ` Simon Marchi
2020-10-02 2:17 ` [PATCH 05/10] Include netbsd_wait " Kamil Rytarowski
2020-10-07 2:58 ` Simon Marchi
2020-10-02 2:18 ` [PATCH 06/10] Include netbsd_waitpid " Kamil Rytarowski
2020-10-02 2:18 ` [PATCH 07/10] Include netbsd_store_waitstatus " Kamil Rytarowski
2020-10-02 2:18 ` [PATCH 08/10] Include netbsd_catch_this_syscall " Kamil Rytarowski
2020-10-07 3:00 ` Simon Marchi
2020-10-02 2:18 ` [PATCH 09/10] Include the functions of qxfer_libraries_svr4 in netbsd_process_target Kamil Rytarowski
2020-10-07 3:02 ` Simon Marchi
2020-10-02 2:18 ` [PATCH 10/10] Fix whitespace formatting Kamil Rytarowski
2020-10-07 3:02 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21fccf3d-3b54-426c-0f7b-6087ab2f353e@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).