public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix gdb.base/list-ambiguous.exp with Clang
Date: Tue, 6 Oct 2020 15:12:54 +0100	[thread overview]
Message-ID: <20201006141254.GA8332@blade.nx> (raw)
In-Reply-To: <c7ce8794-8ec2-818c-d19e-ad52fcb2e36b@palves.net>

Pedro Alves wrote:
> On 10/5/20 12:17 PM, Gary Benson via Gdb-patches wrote:
> > The ambiguous variable parts of gdb.base/list-ambiguous.exp failed
> > when built with Clang because the variable in question was unused
> > and was optimized out.  This commit adds __attribute__ ((used)) to
> > both definitions.
> > 
> > Checked on Fedora 32 x86_64, with GCC and Clang.  Ok to commit?
> 
> OK.

Thanks Pedro, I've pushed this now.

Cheers,
Gary

-- 
Gary Benson - he / him / his
Principal Software Engineer, Red Hat


      reply	other threads:[~2020-10-06 14:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 11:17 Gary Benson
2020-10-06 11:42 ` Pedro Alves
2020-10-06 14:12   ` Gary Benson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006141254.GA8332@blade.nx \
    --to=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).