From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gnulib: Ensure all libraries are used when building gdb/gdbserver
Date: Fri, 9 Oct 2020 09:34:36 +0100 [thread overview]
Message-ID: <20201009083436.GP605036@embecosm.com> (raw)
In-Reply-To: <20201007153319.GL605036@embecosm.com>
* Andrew Burgess <andrew.burgess@embecosm.com> [2020-10-07 16:33:19 +0100]:
> * Simon Marchi <simark@simark.ca> [2020-10-06 10:10:25 -0400]:
>
> > On 2020-10-06 8:17 a.m., Andrew Burgess wrote:
> > > The problem here was me unconditionally trying to include
> > > Makefile.gnulib.inc from the gdb and gdbserver Makefile. The very
> > > first time you run 'make clean' after applying the patch
> > > Makefile.gnulib.inc doesn't exist, but the gdb/gdbserver makefiles
> > > still try to pull the file in unconditionally.
> >
> > If the file is generated at configure-time, I think it would be ok for
> > Makefile.gnulib.inc to be included unconditionally. As when you run
> > "make clean" after pulling some changes, you're supposed to do to it
> > from the top level, so Makefile.gnulib.inc will be created before "make
> > clean" runs in GDB.
>
> OK, I made the include compulsory.
>
> <snip>
>
> >
> > Finally, I don't know if the change was intentional, but the file was
> > previously named Makefile.gnulib.inc and is now named Makefile.gnulib.
> > I liked Makefile.gnulib.inc, as it shows it's not a "top-level"
> > Makefile, it's meant to be included.
>
> I just thought 'Makefile.gnulib.inc.in' was a bit much (in the source
> tree), but I don't really mind. I changed back to use this filename.
>
> The patch below has these two fixes. I'll apply in a couple of days
> unless anyone objects.
I've now pushed this patch.
Thanks,
Andrew
next prev parent reply other threads:[~2020-10-09 8:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 16:51 Andrew Burgess
2020-10-05 18:34 ` Simon Marchi
2020-10-06 12:17 ` Andrew Burgess
2020-10-06 14:10 ` Simon Marchi
2020-10-07 15:33 ` Andrew Burgess
2020-10-07 15:34 ` Simon Marchi
2020-10-09 8:34 ` Andrew Burgess [this message]
2020-10-12 11:41 ` Joel Brobecker
2020-10-12 14:16 ` Simon Marchi
2020-10-12 15:30 ` Andrew Burgess
2020-10-13 14:26 ` Simon Marchi
2020-10-14 14:09 ` Andrew Burgess
2020-10-15 8:35 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009083436.GP605036@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).