public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [committed][gdb/testsuite] Fix gdb.ada/mi_catch_ex{,_hand}.exp FAILs
@ 2020-10-14 11:19 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2020-10-14 11:19 UTC (permalink / raw)
  To: gdb-patches; +Cc: Pedro Alves

Hi,

The test-case gdb.ada/mi_catch_ex.exp tests two scenarios.

The two scenarios are separated by:
- a mi_run_to_main (before commit b75d55d4d2 "Eliminate mi_run_to_main,
  introduce mi_clean_restart")
- a mi_runto_main (after that commit)

The now removed mi_run_to_main contained a mi_delete_breakpoints, while
mi_runto_main does not, which causes FAILs in the second scenario.

Fix this by adding the missing mi_delete_breakpoints in the test-case, and
likewise in gdb.ada/mi_catch_ex_hand.exp.

Reg-tested on x86_64-linux.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Fix gdb.ada/mi_catch_ex{,_hand}.exp FAILs

gdb/testsuite/ChangeLog:

2020-10-14  Tom de Vries  <tdevries@suse.de>

	PR testsuite/26732
	* gdb.ada/mi_catch_ex.exp: Do mi_delete_breakpoints before running
	scenario 2.
	* gdb.ada/mi_catch_ex_hand.exp: Same.

---
 gdb/testsuite/gdb.ada/mi_catch_ex.exp      | 1 +
 gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp | 1 +
 2 files changed, 2 insertions(+)

diff --git a/gdb/testsuite/gdb.ada/mi_catch_ex.exp b/gdb/testsuite/gdb.ada/mi_catch_ex.exp
index 103ec85f86..1d2625aa1a 100644
--- a/gdb/testsuite/gdb.ada/mi_catch_ex.exp
+++ b/gdb/testsuite/gdb.ada/mi_catch_ex.exp
@@ -123,6 +123,7 @@ continue_to_exception \
 #  - continue, the program exits.
 
 with_test_prefix "scenario 2" {
+    mi_delete_breakpoints
     if {[mi_runto_main] < 0} {
 	fail "cannot run to main, testcase aborted"
 	return 0
diff --git a/gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp b/gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp
index ef3dd24979..6e913c1031 100644
--- a/gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp
+++ b/gdb/testsuite/gdb.ada/mi_catch_ex_hand.exp
@@ -116,6 +116,7 @@ continue_to_exception_handler \
 #    but exit instead.
 
 with_test_prefix "scenario 2" {
+    mi_delete_breakpoints
     if {[mi_runto_main] < 0} {
 	fail "cannot run to main, testcase aborted"
 	return 0

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-10-14 11:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 11:19 [committed][gdb/testsuite] Fix gdb.ada/mi_catch_ex{,_hand}.exp FAILs Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).