From: Felix Willgerodt <felix.willgerodt@intel.com>
To: markus.t.metzger@intel.com, gdb-patches@sourceware.org
Subject: [PATCH v3 02/12] btrace: Enable auxiliary instructions in record instruction-history.
Date: Wed, 16 Jun 2021 09:41:55 +0200 [thread overview]
Message-ID: <20210616074205.1129553-3-felix.willgerodt@intel.com> (raw)
In-Reply-To: <20210616074205.1129553-1-felix.willgerodt@intel.com>
Print the auxiliary data when a btrace_insn of type BTRACE_INSN_AUX
is encountered in the instruction-history. Printing is active by default,
it can be silenced with the /a modifier.
This patch is in preparation for the new ptwrite feature, which is based on
auxiliary instructions.
gdb/ChangeLog:
2021-06-14 Felix Willgerodt <felix.willgerodt@intel.com>
* record-btrace.c (btrace_insn_history): Handle BTRACE_INSN_AUX.
* record.c (get_insn_history_modifiers): Add /a modifier.
* disasm.h (gdb_disassembly_flag): Add DISASSEMBLY_OMIT_AUX_INSN.
gdb/doc/ChangeLog:
2021-06-14 Felix Willgerodt <felix.willgerodt@intel.com>
* gdb.texinfo (record instruction history): Document /a modifier.
---
gdb/disasm.h | 1 +
gdb/doc/gdb.texinfo | 3 +++
gdb/record-btrace.c | 13 +++++++++++++
gdb/record.c | 5 +++++
4 files changed, 22 insertions(+)
diff --git a/gdb/disasm.h b/gdb/disasm.h
index eb82bc3cd01..4db5bd943eb 100644
--- a/gdb/disasm.h
+++ b/gdb/disasm.h
@@ -31,6 +31,7 @@ enum gdb_disassembly_flag
DISASSEMBLY_OMIT_PC = (0x1 << 4),
DISASSEMBLY_SOURCE = (0x1 << 5),
DISASSEMBLY_SPECULATIVE = (0x1 << 6),
+ DISASSEMBLY_OMIT_AUX_INSN = (0x1 << 7),
};
DEF_ENUM_FLAGS_TYPE (enum gdb_disassembly_flag, gdb_disassembly_flags);
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index ff4f41941d3..8f49a91347f 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -7883,6 +7883,9 @@ To better align the printed instructions when the trace contains
instructions from more than one function, the function name may be
omitted by specifying the @code{/f} modifier.
+Printing auxiliary information is enabled by default and can be
+omitted with the @code{/a} modifier.
+
Speculatively executed instructions are prefixed with @samp{?}. This
feature is not available for all recording formats.
diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c
index 00affb85d22..96c1b69cb0f 100644
--- a/gdb/record-btrace.c
+++ b/gdb/record-btrace.c
@@ -821,6 +821,19 @@ btrace_insn_history (struct ui_out *uiout,
btrace_ui_out_decode_error (uiout, btrace_insn_get_error (&it),
conf->format);
}
+ else if (insn->iclass == BTRACE_INSN_AUX)
+ {
+ if ((flags & DISASSEMBLY_OMIT_AUX_INSN) != 0)
+ continue;
+
+ uiout->field_fmt ("insn-number", "%u", btrace_insn_number (&it));
+ uiout->text ("\t");
+ uiout->spaces (3);
+ uiout->text ("[");
+ uiout->field_fmt ("aux-data", "%s",
+ it.btinfo->aux_data[insn->aux_data_index].c_str ());
+ uiout->text ("]\n");
+ }
else
{
struct disasm_insn dinsn;
diff --git a/gdb/record.c b/gdb/record.c
index 6968c30d930..084c8a12c16 100644
--- a/gdb/record.c
+++ b/gdb/record.c
@@ -486,6 +486,9 @@ get_insn_history_modifiers (const char **arg)
switch (*args)
{
+ case 'a':
+ modifiers |= DISASSEMBLY_OMIT_AUX_INSN;
+ break;
case 'm':
case 's':
modifiers |= DISASSEMBLY_SOURCE;
@@ -854,6 +857,8 @@ With a /m or /s modifier, source lines are included (if available).\n\
With a /r modifier, raw instructions in hex are included.\n\
With a /f modifier, function names are omitted.\n\
With a /p modifier, current position markers are omitted.\n\
+With a /a modifier, omits output of auxiliary data, which is enabled \
+by default.\n\
With no argument, disassembles ten more instructions after the previous \
disassembly.\n\
\"record instruction-history -\" disassembles ten instructions before a \
--
2.25.4
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2021-06-16 7:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 7:41 [PATCH v3 00/12] Extensions for PTWRITE Felix Willgerodt
2021-06-16 7:41 ` [PATCH v3 01/12] btrace: Introduce auxiliary instructions Felix Willgerodt
2021-08-12 11:06 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2021-06-16 7:41 ` Felix Willgerodt [this message]
2021-08-12 11:06 ` [PATCH v3 02/12] btrace: Enable auxiliary instructions in record instruction-history Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2021-06-16 7:41 ` [PATCH v3 03/12] btrace: Enable auxiliary instructions in record function-call-history Felix Willgerodt
2021-08-12 11:14 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2021-06-16 7:41 ` [PATCH v3 04/12] btrace: Handle stepping and goto for auxiliary instructions Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2021-06-16 7:41 ` [PATCH v3 05/12] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2021-06-16 7:41 ` [PATCH v3 06/12] python: Add clear() to gdb.Record Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2021-06-16 7:42 ` [PATCH v3 07/12] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2022-05-10 13:59 ` Metzger, Markus T
2022-06-24 6:57 ` Willgerodt, Felix
2021-06-16 7:42 ` [PATCH v3 08/12] btrace, linux: Enable ptwrite packets Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2021-06-16 7:42 ` [PATCH v3 09/12] btrace, python: Enable ptwrite listener registration Felix Willgerodt
2021-08-13 10:36 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2022-05-30 14:55 ` Metzger, Markus T
2022-05-31 11:26 ` Willgerodt, Felix
2022-05-31 11:50 ` Eli Zaretskii
2021-06-16 7:42 ` [PATCH v3 10/12] btrace, python: Enable calling the ptwrite listener Felix Willgerodt
2021-08-13 10:36 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2022-05-30 15:01 ` Metzger, Markus T
2021-06-16 7:42 ` [PATCH v3 11/12] gdb, testsuite, lib: Add libipt version check Felix Willgerodt
2021-08-13 10:36 ` Metzger, Markus T
2022-05-02 9:55 ` Willgerodt, Felix
2021-06-16 7:42 ` [PATCH v3 12/12] btrace: Extend ptwrite event decoding Felix Willgerodt
2021-06-17 7:00 ` Eli Zaretskii
2021-06-17 11:51 ` Willgerodt, Felix
2021-08-13 13:36 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616074205.1129553-3-felix.willgerodt@intel.com \
--to=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).