From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v3 01/12] btrace: Introduce auxiliary instructions.
Date: Fri, 6 May 2022 11:26:13 +0000 [thread overview]
Message-ID: <MN2PR11MB4566052B466FF4C233403ABB8EC59@MN2PR11MB4566.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM8PR11MB5749001BFF6D7AAE20BF265ADEF99@DM8PR11MB5749.namprd11.prod.outlook.com>
Sorry for taking so long again, answers below.
> -----Original Message-----
> From: Metzger, Markus T <markus.t.metzger@intel.com>
> Sent: Donnerstag, 12. August 2021 13:07
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: RE: [PATCH v3 01/12] btrace: Introduce auxiliary instructions.
>
> Thanks, Felix,
>
> The patch looks good with two small nits.
>
> > /* Instruction flags. */
> >@@ -68,8 +71,19 @@ DEF_ENUM_FLAGS_TYPE (enum btrace_insn_flag,
> >btrace_insn_flags);
> > This represents a single instruction in a branch trace. */
> > struct btrace_insn
> > {
> >- /* The address of this instruction. */
> >- CORE_ADDR pc;
> >+ union
> >+ {
> >+ /* The address of this instruction. Applies to btrace_insn with
> >+ iclass == BTRACE_INSN_OTHER or
> >+ iclass == BTRACE_INSN_CALL or
> >+ iclass == BTRACE_INSN_RETURN or
> >+ iclass == BTRACE_INSN_JUMP. */
> >+ CORE_ADDR pc;
> >+
> >+ /* Index into btrace_info::aux_data. Applies to btrace_insn with
> >+ iclass == BTRACE_INSN_AUX. */
> >+ uint64_t aux_data_index;
> >+ };
>
> Should we add size to the union, too, or is this needed for AUX instructions?
> How about a name for the union?
Size is not needed for AUX right now and I don't think it ever will be.
If I would add it to the union, I would need to come up with another struct that
included pc and size to put them in the union. And touch all users.
I don't see too much benefit, but I can do that if you prefer.
I explicitly didn't name it to prevent touching all users.
>
> > /* The size of this instruction in bytes. */
> > gdb_byte size;
> >@@ -330,6 +344,10 @@ struct btrace_thread_info
> > function segment i will be at index (i - 1). */
> > std::vector<btrace_function> functions;
> >
> >+ /* Optional auxiliary data that is printed in all commands displaying or
> >+ stepping through the execution history. */
> >+ std::vector<std::string> aux_data;
>
> This is not the data itself but a human-readable representation, correct?
> Should we say 'information' instead of 'data'?
>
I changed it to information.
> Regards,
> Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-05-06 11:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 7:41 [PATCH v3 00/12] Extensions for PTWRITE Felix Willgerodt
2021-06-16 7:41 ` [PATCH v3 01/12] btrace: Introduce auxiliary instructions Felix Willgerodt
2021-08-12 11:06 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix [this message]
2021-06-16 7:41 ` [PATCH v3 02/12] btrace: Enable auxiliary instructions in record instruction-history Felix Willgerodt
2021-08-12 11:06 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2021-06-16 7:41 ` [PATCH v3 03/12] btrace: Enable auxiliary instructions in record function-call-history Felix Willgerodt
2021-08-12 11:14 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2021-06-16 7:41 ` [PATCH v3 04/12] btrace: Handle stepping and goto for auxiliary instructions Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2021-06-16 7:41 ` [PATCH v3 05/12] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2021-06-16 7:41 ` [PATCH v3 06/12] python: Add clear() to gdb.Record Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2021-06-16 7:42 ` [PATCH v3 07/12] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2022-05-10 13:59 ` Metzger, Markus T
2022-06-24 6:57 ` Willgerodt, Felix
2021-06-16 7:42 ` [PATCH v3 08/12] btrace, linux: Enable ptwrite packets Felix Willgerodt
2021-08-12 11:07 ` Metzger, Markus T
2021-06-16 7:42 ` [PATCH v3 09/12] btrace, python: Enable ptwrite listener registration Felix Willgerodt
2021-08-13 10:36 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2022-05-30 14:55 ` Metzger, Markus T
2022-05-31 11:26 ` Willgerodt, Felix
2022-05-31 11:50 ` Eli Zaretskii
2021-06-16 7:42 ` [PATCH v3 10/12] btrace, python: Enable calling the ptwrite listener Felix Willgerodt
2021-08-13 10:36 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
2022-05-30 15:01 ` Metzger, Markus T
2021-06-16 7:42 ` [PATCH v3 11/12] gdb, testsuite, lib: Add libipt version check Felix Willgerodt
2021-08-13 10:36 ` Metzger, Markus T
2022-05-02 9:55 ` Willgerodt, Felix
2021-06-16 7:42 ` [PATCH v3 12/12] btrace: Extend ptwrite event decoding Felix Willgerodt
2021-06-17 7:00 ` Eli Zaretskii
2021-06-17 11:51 ` Willgerodt, Felix
2021-08-13 13:36 ` Metzger, Markus T
2022-05-06 11:26 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4566052B466FF4C233403ABB8EC59@MN2PR11MB4566.namprd11.prod.outlook.com \
--to=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).