public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdb: add .flake8 file
@ 2021-06-23  0:29 Simon Marchi
  2021-06-28 18:24 ` Tom Tromey
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2021-06-23  0:29 UTC (permalink / raw)
  To: gdb-patches

Add a .flake8 file, which is used to set default options to the flake8
Python linter.  Use it to disable these two kinds of diagnostics, which
we don't care about since formatting is handled by black.  This reduces
the amount of noise when running flake8 on Python files.

    ./python/lib/gdb/function/caller_is.py:30:80: E501 line too long (81 > 79 characters)
    ./python/lib/gdb/command/frame_filters.py:468:17: W503 line break before binary operator

gdb/ChangeLog:

	* .flake8: New.

Change-Id: I2b41379fdd1f6e8bf2a784d55a10b406e4d1c828
---
 gdb/.flake8 | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 gdb/.flake8

diff --git a/gdb/.flake8 b/gdb/.flake8
new file mode 100644
index 000000000000..a6f727b8d5f7
--- /dev/null
+++ b/gdb/.flake8
@@ -0,0 +1,2 @@
+[flake8]
+ignore = E501, W503
-- 
2.32.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdb: add .flake8 file
  2021-06-23  0:29 [PATCH] gdb: add .flake8 file Simon Marchi
@ 2021-06-28 18:24 ` Tom Tromey
  2021-06-28 19:27   ` Simon Marchi
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2021-06-28 18:24 UTC (permalink / raw)
  To: Simon Marchi via Gdb-patches

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> Add a .flake8 file, which is used to set default options to the flake8
Simon> Python linter.  Use it to disable these two kinds of diagnostics, which
Simon> we don't care about since formatting is handled by black.  This reduces
Simon> the amount of noise when running flake8 on Python files.

Simon>     ./python/lib/gdb/function/caller_is.py:30:80: E501 line too long (81 > 79 characters)
Simon>     ./python/lib/gdb/command/frame_filters.py:468:17: W503 line break before binary operator

Simon> gdb/ChangeLog:

Simon> 	* .flake8: New.

Seems fine to me.

thanks,
Tom

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gdb: add .flake8 file
  2021-06-28 18:24 ` Tom Tromey
@ 2021-06-28 19:27   ` Simon Marchi
  0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2021-06-28 19:27 UTC (permalink / raw)
  To: Tom Tromey, Simon Marchi via Gdb-patches



On 2021-06-28 2:24 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Add a .flake8 file, which is used to set default options to the flake8
> Simon> Python linter.  Use it to disable these two kinds of diagnostics, which
> Simon> we don't care about since formatting is handled by black.  This reduces
> Simon> the amount of noise when running flake8 on Python files.
> 
> Simon>     ./python/lib/gdb/function/caller_is.py:30:80: E501 line too long (81 > 79 characters)
> Simon>     ./python/lib/gdb/command/frame_filters.py:468:17: W503 line break before binary operator
> 
> Simon> gdb/ChangeLog:
> 
> Simon> 	* .flake8: New.
> 
> Seems fine to me.
> 
> thanks,
> Tom
> 

Pushed, thanks.

Simon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-28 19:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23  0:29 [PATCH] gdb: add .flake8 file Simon Marchi
2021-06-28 18:24 ` Tom Tromey
2021-06-28 19:27   ` Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).