[PATCH] selftest-arch: free arches array

[PATCH] selftest-arch: free arches array

[Alexandra Hájková]

From: Alexandra Hájková <ahajkova@redhat.com>

Found by coverity scanning.

gdb/ChangeLog:

2021-07-02 Alexandra Hájková <ahajkova@redhat.com>

	* selftest-arch.c (struct gdbarch_selftest): free arches array
---
 gdb/selftest-arch.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/selftest-arch.c b/gdb/selftest-arch.c
index 0eef134d484..03b07108a2e 100644
--- a/gdb/selftest-arch.c
+++ b/gdb/selftest-arch.c
@@ -79,7 +79,9 @@ struct gdbarch_selftest : public selftest
 	  }
 
 	reset ();
+        free((char *)arches[i]);
       }
+      free(arches);
 
     SELF_CHECK (pass);
   }
-- 
2.26.3

Re: [PATCH] selftest-arch: free arches array

[Simon Marchi]

On 2021-07-02 6:56 a.m., Alexandra Hájková via Gdb-patches wrote:
> From: Alexandra Hájková <ahajkova@redhat.com>
> 
> Found by coverity scanning.
> 
> gdb/ChangeLog:
> 
> 2021-07-02 Alexandra Hájková <ahajkova@redhat.com>
> 
> 	* selftest-arch.c (struct gdbarch_selftest): free arches array
> ---
>   gdb/selftest-arch.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/gdb/selftest-arch.c b/gdb/selftest-arch.c
> index 0eef134d484..03b07108a2e 100644
> --- a/gdb/selftest-arch.c
> +++ b/gdb/selftest-arch.c
> @@ -79,7 +79,9 @@ struct gdbarch_selftest : public selftest
>   	  }
>   
>   	reset ();
> +        free((char *)arches[i]);

I don't think the elements of the array need to be freed, as here in 
gdbarch_printable_names, we just push the pointer handed by BFD, we 
don't duplicate the strings:

https://gitlab.com/gnutools/gdb/-/blob/3bdd3c041881470878cf47250a825a94d381fa64/gdb/gdbarch.c#L5580


>         }
> +      free(arches);

For this, I would suggest modernizing gdbarch_printable_names by making 
it return an std::vector instead.  It will simplify that code 
(gdbarch_printable_names) as well as the callers, making memory 
management automatic.

Simon