public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [committed][gdb/testsuite] Fix full buffer in gdb.rust/dwindex.exp
@ 2021-09-30 10:02 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2021-09-30 10:02 UTC (permalink / raw)
  To: gdb-patches

Hi,

On ubuntu 18.04.5, I run into:
...
(gdb) mt print objfiles dwindex^M
^M
Object file build/gdb/testsuite/outputs/gdb.rust/dwindex/dwindex:  \
  Objfile at 0x55dab0b87a50, bfd at 0x55dab0b0cfa0, 1095 minsyms^M
^M
Psymtabs:^M
vendor/compiler_builtins/src/int/specialized_div_rem/mod.rs at 0x55dab0db0720^M
  ...
library/std/src/sys/unix/stdio.rs at 0x55dab0d96320^M
ERROR: internal buffer is full.
UNRESOLVED: gdb.rust/dwindex.exp: check if index present
...

Fix this by using -lbl in proc ensure_gdb_index.

Tested on x86_64-linux.

Committed to trunk.

Thanks,
- Tom

[gdb/testsuite] Fix full buffer in gdb.rust/dwindex.exp

---
 gdb/testsuite/lib/gdb.exp | 34 ++++++++++++++++++++++++----------
 1 file changed, 24 insertions(+), 10 deletions(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index b7f3a57c4d9..afdc92eec3f 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -7917,22 +7917,36 @@ proc add_gdb_index { program {style ""} } {
 # string (the default) means .gdb_index; "-dwarf-5" means .debug_names.
 
 proc ensure_gdb_index { binfile {style ""} } {
+    global decimal
+
     set testfile [file tail $binfile]
     set test "check if index present"
-    gdb_test_multiple "mt print objfiles ${testfile}" $test {
-	-re -wrap "gdb_index.*" {
-	    return 0
+    set has_index 0
+    gdb_test_multiple "mt print objfiles ${testfile}" $test -lbl {
+	-re "\r\n\\.gdb_index: version ${decimal}(?=\r\n)" {
+	    set has_index 1
+	    gdb_test_lines "" $gdb_test_name ".*"
 	}
-	-re -wrap "debug_names.*" {
-	    return 0
+	-re "\r\n\\.debug_names: exists(?=\r\n)" {
+	    set has_index 1
+	    gdb_test_lines "" $gdb_test_name ".*"
 	}
-	-re -wrap "Psymtabs.*" {
-	    if { [add_gdb_index $binfile $style] != "1" } {
-		return -1
-	    }
-	    return 1
+	-re "\r\nPsymtabs:(?=\r\n)" {
+	    gdb_test_lines "" $gdb_test_name ".*"
 	}
+	-re -wrap "" {
+	    fail $gdb_test_name
+	}
+    }
+
+    if { $has_index } {
+	return 0
     }
+
+    if { [add_gdb_index $binfile $style] == "1" } {
+	return 1
+    }
+
     return -1
 }
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-30 10:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 10:02 [committed][gdb/testsuite] Fix full buffer in gdb.rust/dwindex.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).