* [committed][gdb/testsuite] Check compilation result in gdb.base/call-sc.exp
@ 2021-09-30 17:09 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2021-09-30 17:09 UTC (permalink / raw)
To: gdb-patches
Hi,
When running test-case gdb.base/call-sc.exp with target board unix/-bad, I
get:
...
gdb compile failed, gcc: error: unrecognized command line option '-bad'
UNTESTED: gdb.base/call-sc.exp: failed to prepare
ERROR: tcl error sourcing src/gdb/testsuite/gdb.base/call-sc.exp.
ERROR: can't read "use_gdb_stub": no such variable
...
Fix this by checking the compilation result.
Fix the resulting DUPLICATE:
...
DUPLICATE: gdb.base/call-sc.exp: failed to prepare
...
using with_test_prefix.
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Check compilation result in gdb.base/call-sc.exp
---
gdb/testsuite/gdb.base/call-sc.exp | 45 +++++++++++++++-----------------------
1 file changed, 18 insertions(+), 27 deletions(-)
diff --git a/gdb/testsuite/gdb.base/call-sc.exp b/gdb/testsuite/gdb.base/call-sc.exp
index 6b712a39ac6..5ba72a54a1f 100644
--- a/gdb/testsuite/gdb.base/call-sc.exp
+++ b/gdb/testsuite/gdb.base/call-sc.exp
@@ -393,10 +393,17 @@ proc test_scalar_returns { } {
# Test every single char struct from 1..17 in size. This is what the
# original "scalars" test was doing.
-start_scalars_test tc
-test_scalar_calls
-test_scalar_returns
+proc test { type } {
+ with_test_prefix $type {
+ if { [start_scalars_test $type] == -1 } {
+ return
+ }
+ test_scalar_calls
+ test_scalar_returns
+ }
+}
+test tc
# Let the fun begin.
@@ -413,45 +420,29 @@ test_scalar_returns
# naturally aligned. Padding being added where needed.
# Approx size: 2, 4, ...
-start_scalars_test ts
-test_scalar_calls
-test_scalar_returns
+test ts
# Approx size: 4, 8, ...
-start_scalars_test ti
-test_scalar_calls
-test_scalar_returns
+test ti
# Approx size: 4, 8, ...
-start_scalars_test tl
-test_scalar_calls
-test_scalar_returns
+test tl
# Approx size: 8, 16, ...
-start_scalars_test tll
-test_scalar_calls
-test_scalar_returns
+test tll
if {!$skip_float_test} {
# Approx size: 4, 8, ...
- start_scalars_test tf
- test_scalar_calls
- test_scalar_returns
+ test tf
# Approx size: 8, 16, ...
- start_scalars_test td
- test_scalar_calls
- test_scalar_returns
+ test td
# Approx size: 16, 32, ...
- start_scalars_test tld
- test_scalar_calls
- test_scalar_returns
+ test tld
}
# Approx size: 4, 8, ...
-start_scalars_test te
-test_scalar_calls
-test_scalar_returns
+test te
return 0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-30 17:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 17:09 [committed][gdb/testsuite] Check compilation result in gdb.base/call-sc.exp Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).