From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH v3 28/33] Genericize addrmap handling in the DWARF index writer
Date: Sat, 4 Dec 2021 13:38:39 -0700 [thread overview]
Message-ID: <20211204203844.1188999-29-tom@tromey.com> (raw)
In-Reply-To: <20211204203844.1188999-1-tom@tromey.com>
This updates the DWARF index writing code to make the addrmap-writing
a bit more generic. Now, it can handle multiple maps, and it can work
using the maps generated by the new indexer.
Note that the new addrmap_index_data::using_index field will be
deleted in a future patch, when the rest of the DWARF psymtab code is
removed.
---
gdb/dwarf2/index-write.c | 37 ++++++++++++++++++++++++++++---------
1 file changed, 28 insertions(+), 9 deletions(-)
diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c
index 8bf7e8fdd1c..13b929fea54 100644
--- a/gdb/dwarf2/index-write.c
+++ b/gdb/dwarf2/index-write.c
@@ -412,8 +412,11 @@ typedef std::unordered_map<dwarf2_per_cu_data *, unsigned int> cu_index_map;
/* Helper struct for building the address table. */
struct addrmap_index_data
{
- addrmap_index_data (data_buf &addr_vec_, cu_index_map &cu_index_htab_)
- : addr_vec (addr_vec_), cu_index_htab (cu_index_htab_)
+ addrmap_index_data (data_buf &addr_vec_, cu_index_map &cu_index_htab_,
+ bool using_index_)
+ : addr_vec (addr_vec_),
+ cu_index_htab (cu_index_htab_),
+ using_index (using_index_)
{}
data_buf &addr_vec;
@@ -421,6 +424,8 @@ struct addrmap_index_data
int operator() (CORE_ADDR start_addr, void *obj);
+ /* True if the DWARF reader uses the new DWARF indexer. */
+ bool using_index;
/* True if the previous_* fields are valid.
We can't write an entry until we see the next entry (since it is only then
that we know the end of the entry). */
@@ -447,7 +452,11 @@ add_address_entry (data_buf &addr_vec,
int
addrmap_index_data::operator() (CORE_ADDR start_addr, void *obj)
{
- dwarf2_psymtab *pst = (dwarf2_psymtab *) obj;
+ dwarf2_per_cu_data *per_cu;
+ if (using_index)
+ per_cu = (dwarf2_per_cu_data *) obj;
+ else
+ per_cu = obj == nullptr ? nullptr : ((dwarf2_psymtab *) obj)->per_cu_data;
if (previous_valid)
add_address_entry (addr_vec,
@@ -455,9 +464,9 @@ addrmap_index_data::operator() (CORE_ADDR start_addr, void *obj)
previous_cu_index);
previous_cu_start = start_addr;
- if (pst != NULL)
+ if (per_cu != NULL)
{
- const auto it = cu_index_htab.find (pst->per_cu_data);
+ const auto it = cu_index_htab.find (per_cu);
gdb_assert (it != cu_index_htab.cend ());
previous_cu_index = it->second;
previous_valid = true;
@@ -474,9 +483,10 @@ addrmap_index_data::operator() (CORE_ADDR start_addr, void *obj)
static void
write_address_map (struct addrmap *addrmap, data_buf &addr_vec,
- cu_index_map &cu_index_htab)
+ cu_index_map &cu_index_htab, bool using_index)
{
- struct addrmap_index_data addrmap_index_data (addr_vec, cu_index_htab);
+ struct addrmap_index_data addrmap_index_data (addr_vec, cu_index_htab,
+ using_index);
addrmap_foreach (addrmap, addrmap_index_data);
@@ -1377,8 +1387,17 @@ write_gdbindex (dwarf2_per_objfile *per_objfile, FILE *out_file,
/* Dump the address map. */
data_buf addr_vec;
- write_address_map (per_objfile->per_bfd->partial_symtabs->psymtabs_addrmap,
- addr_vec, cu_index_htab);
+ if (per_objfile->per_bfd->using_index)
+ {
+ std::vector<addrmap *> addrmaps
+ = per_objfile->per_bfd->cooked_index_table->get_addrmaps ();
+ for (auto map : addrmaps)
+ write_address_map (map, addr_vec, cu_index_htab, true);
+ }
+ else
+ write_address_map (per_objfile->per_bfd->partial_symtabs->psymtabs_addrmap,
+ addr_vec, cu_index_htab,
+ per_objfile->per_bfd->using_index);
/* Now that we've processed all symbols we can shrink their cu_indices
lists. */
--
2.31.1
next prev parent reply other threads:[~2021-12-04 20:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 20:38 [PATCH v3 00/33] Rewrite the DWARF "partial" reader Tom Tromey
2021-12-04 20:38 ` [PATCH v3 01/33] Split create_addrmap_from_aranges Tom Tromey
2021-12-04 20:38 ` [PATCH v3 02/33] Fix latent bug in read_addrmap_from_aranges Tom Tromey
2021-12-04 20:38 ` [PATCH v3 03/33] Add dwarf2_per_cu_data::addresses_seen Tom Tromey
2021-12-04 20:38 ` [PATCH v3 04/33] Refactor dwarf2_get_pc_bounds Tom Tromey
2021-12-04 20:38 ` [PATCH v3 05/33] Allow ada_decode not to decode operators Tom Tromey
2021-12-04 20:38 ` [PATCH v3 06/33] Let skip_one_die not skip children Tom Tromey
2021-12-04 20:38 ` [PATCH v3 07/33] Add name splitting Tom Tromey
2021-12-04 20:38 ` [PATCH v3 08/33] Add new overload of dwarf5_djb_hash Tom Tromey
2021-12-04 20:38 ` [PATCH v3 09/33] Refactor build_type_psymtabs_reader Tom Tromey
2021-12-04 20:38 ` [PATCH v3 10/33] Add batching parameter to parallel_for_each Tom Tromey
2021-12-04 20:38 ` [PATCH v3 11/33] Return vector of results from parallel_for_each Tom Tromey
2022-03-29 17:36 ` Pedro Alves
2022-03-29 20:07 ` Tom Tromey
2021-12-04 20:38 ` [PATCH v3 12/33] Specialize std::hash for gdb_exception Tom Tromey
2021-12-04 20:38 ` [PATCH v3 13/33] Add "fullname" handling to file_and_directory Tom Tromey
2021-12-07 17:17 ` Tom Tromey
2021-12-04 20:38 ` [PATCH v3 14/33] Introduce DWARF abbrev cache Tom Tromey
2021-12-04 20:38 ` [PATCH v3 15/33] Statically examine abbrev properties Tom Tromey
2021-12-04 20:38 ` [PATCH v3 16/33] Update skip_one_die for new " Tom Tromey
2021-12-04 20:38 ` [PATCH v3 17/33] Introduce the new DWARF index class Tom Tromey
2021-12-04 20:38 ` [PATCH v3 18/33] The new DWARF indexer Tom Tromey
2022-03-29 18:04 ` Pedro Alves
2022-03-29 20:08 ` Tom Tromey
2021-12-04 20:38 ` [PATCH v3 19/33] Implement quick_symbol_functions for cooked DWARF index Tom Tromey
2021-12-04 20:38 ` [PATCH v3 20/33] Wire in the new DWARF indexer Tom Tromey
2021-12-04 20:38 ` [PATCH v3 21/33] Introduce thread-safe handling for complaints Tom Tromey
2021-12-04 20:38 ` [PATCH v3 22/33] Pre-read DWARF section data Tom Tromey
2021-12-04 20:38 ` [PATCH v3 23/33] Parallelize DWARF indexing Tom Tromey
2022-03-30 10:24 ` Pedro Alves
2022-03-30 20:23 ` Tom Tromey
2022-03-30 21:24 ` Tom Tromey
2021-12-04 20:38 ` [PATCH v3 24/33] "Finalize" the DWARF index in the background Tom Tromey
2021-12-04 20:38 ` [PATCH v3 25/33] Rename write_psymtabs_to_index Tom Tromey
2021-12-04 20:38 ` [PATCH v3 26/33] Change the key type in psym_index_map Tom Tromey
2021-12-04 20:38 ` [PATCH v3 27/33] Change parameters to write_address_map Tom Tromey
2021-12-04 20:38 ` Tom Tromey [this message]
2021-12-04 20:38 ` [PATCH v3 29/33] Adapt .gdb_index writer to new DWARF scanner Tom Tromey
2021-12-04 20:38 ` [PATCH v3 30/33] Adapt .debug_names " Tom Tromey
2021-12-04 20:38 ` [PATCH v3 31/33] Enable the new DWARF indexer Tom Tromey
2021-12-04 20:38 ` [PATCH v3 32/33] Delete DWARF psymtab code Tom Tromey
2021-12-04 20:38 ` [PATCH v3 33/33] Remove dwarf2_per_cu_data::v Tom Tromey
2022-01-05 17:18 ` [PATCH v3 00/33] Rewrite the DWARF "partial" reader Tom Tromey
2022-03-24 16:18 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211204203844.1188999-29-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).