Re: [PATCH v3 11/33] Return vector of results from parallel_for_each

[Pedro Alves <pedro@palves.net>]

Hi Tom,

Just a nit that I noticed while skimming the series.

(please don't wait for a full review of the series from me.)

On 2021-12-04 20:38, Tom Tromey wrote:

> +  /* Invoke TASK in the current thread, then compute all the results
> +     from all background tasks and put them into a result vector,
> +     which is returned.  */
> +  result_type finish (std::function<T ()> task)

Since TASK is always executed in the current thread, it can be a gdb::function_view
instead of a std::function.

> +  {
> +    result_type result (m_futures.size () + 1);
> +
> +    result.back () = task ();
> +
> +    for (size_t i = 0; i < m_futures.size (); ++i)
> +      result[i] = m_futures[i].get ();
> +
> +    return result;
> +  }
> +
> +private:
> +  


> +  result_type finish (std::function<void ()> task)
> +  {

Ditto for the void specialization.

> +    task ();
> +
> +    for (auto &future : m_futures)
> +      {
> +	/* Use 'get' and not 'wait', to propagate any exception.  */
> +	future.get ();
> +      }
> +  }
> +