* [PATCH] gdb-add-index: disable debuginfod
@ 2022-02-12 0:28 Aaron Merey
2022-02-25 19:23 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Aaron Merey @ 2022-02-12 0:28 UTC (permalink / raw)
To: gdb-patches
gdb-add-index may trigger debuginfod's first-use notice. The notice
is misleading in this case. It instructs the user to modify .gdbinit
in order to permanently enable/disable debuginfod but gdb-add-index
invokes gdb with -nx which ignores .gdbinit.
Additionally debuginfod is not needed for gdb-add-index since the
symbol file is given as an argument and should already be present
locally.
Fix this by disabling debuginfod when gdb-add-index invokes gdb.
---
gdb/contrib/gdb-add-index.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh
index 0ff943d506e..591f32bbbbe 100755
--- a/gdb/contrib/gdb-add-index.sh
+++ b/gdb/contrib/gdb-add-index.sh
@@ -112,6 +112,7 @@ rm -f $tmp_files
trap "rm -f $tmp_files" 0
$GDB --batch -nx -iex 'set auto-load no' \
+ -iex 'set debuginfod enabled off' \
-ex "file $file" -ex "save gdb-index $dwarf5 $dir" || {
# Just in case.
status=$?
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gdb-add-index: disable debuginfod
2022-02-12 0:28 [PATCH] gdb-add-index: disable debuginfod Aaron Merey
@ 2022-02-25 19:23 ` Tom Tromey
2022-02-25 22:35 ` Aaron Merey
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2022-02-25 19:23 UTC (permalink / raw)
To: Aaron Merey via Gdb-patches
>>>>> "Aaron" == Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:
Aaron> gdb-add-index may trigger debuginfod's first-use notice. The notice
Aaron> is misleading in this case. It instructs the user to modify .gdbinit
Aaron> in order to permanently enable/disable debuginfod but gdb-add-index
Aaron> invokes gdb with -nx which ignores .gdbinit.
Aaron> Additionally debuginfod is not needed for gdb-add-index since the
Aaron> symbol file is given as an argument and should already be present
Aaron> locally.
Aaron> Fix this by disabling debuginfod when gdb-add-index invokes gdb.
Thank you. This is ok.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-25 22:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-12 0:28 [PATCH] gdb-add-index: disable debuginfod Aaron Merey
2022-02-25 19:23 ` Tom Tromey
2022-02-25 22:35 ` Aaron Merey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).