From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 02/18] Boolify need_escape in generic_emit_char
Date: Wed, 16 Feb 2022 15:39:41 +0000 [thread overview]
Message-ID: <20220216153941.GF2571@redhat.com> (raw)
In-Reply-To: <20220216135518.3162480-3-tom@tromey.com>
* Tom Tromey <tom@tromey.com> [2022-02-16 06:55:02 -0700]:
> This changes 'need_escape' in generic_emit_char to be of type bool,
> rather than int.
LGTM.
Thanks,
Andrew
> ---
> gdb/valprint.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gdb/valprint.c b/gdb/valprint.c
> index e4d68381189..e758c1d1066 100644
> --- a/gdb/valprint.c
> +++ b/gdb/valprint.c
> @@ -2191,11 +2191,11 @@ print_wchar (gdb_wint_t w, const gdb_byte *orig,
> int orig_len, int width,
> enum bfd_endian byte_order,
> struct obstack *output,
> - int quoter, int *need_escapep)
> + int quoter, bool *need_escapep)
> {
> - int need_escape = *need_escapep;
> + bool need_escape = *need_escapep;
>
> - *need_escapep = 0;
> + *need_escapep = false;
>
> /* iswprint implementation on Windows returns 1 for tab character.
> In order to avoid different printout on this host, we explicitly
> @@ -2265,7 +2265,7 @@ print_wchar (gdb_wint_t w, const gdb_byte *orig,
> ++i;
> }
>
> - *need_escapep = 1;
> + *need_escapep = true;
> }
> break;
> }
> @@ -2283,7 +2283,7 @@ generic_emit_char (int c, struct type *type, struct ui_file *stream,
> enum bfd_endian byte_order
> = type_byte_order (type);
> gdb_byte *c_buf;
> - int need_escape = 0;
> + bool need_escape = false;
>
> c_buf = (gdb_byte *) alloca (TYPE_LENGTH (type));
> pack_long (c_buf, type, c);
> @@ -2448,7 +2448,7 @@ print_converted_chars_to_obstack (struct obstack *obstack,
> const converted_character *elem;
> enum {START, SINGLE, REPEAT, INCOMPLETE, FINISH} state, last;
> gdb_wchar_t wide_quote_char = gdb_btowc (quote_char);
> - int need_escape = 0;
> + bool need_escape = false;
>
> /* Set the start state. */
> idx = 0;
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-02-16 15:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 13:55 [PATCH 00/18] Refactor character printing Tom Tromey
2022-02-16 13:55 ` [PATCH 01/18] Fix latent quote char bug in generic_printstr Tom Tromey
2022-02-16 15:38 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 02/18] Boolify need_escape in generic_emit_char Tom Tromey
2022-02-16 15:39 ` Andrew Burgess [this message]
2022-02-16 13:55 ` [PATCH 03/18] Remove c_emit_char Tom Tromey
2022-02-16 15:40 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 04/18] Remove c_printstr Tom Tromey
2022-02-16 15:46 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 05/18] Don't use wchar_printable in print_wchar Tom Tromey
2022-02-16 15:52 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 06/18] Fix a latent bug " Tom Tromey
2022-02-16 16:02 ` Andrew Burgess
2022-02-17 22:02 ` Tom Tromey
2022-02-16 13:55 ` [PATCH 07/18] Remove language_defn::emitchar Tom Tromey
2022-02-16 16:12 ` Andrew Burgess
2022-02-17 22:02 ` Tom Tromey
2022-02-16 13:55 ` [PATCH 08/18] Add gdb_iswcntrl Tom Tromey
2022-02-16 16:13 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 09/18] Include \0 in printable wide characters Tom Tromey
2022-02-16 17:19 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 10/18] Use a ui_file in print_wchar Tom Tromey
2022-02-16 17:25 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 11/18] Add an emitter callback to generic_printstr and generic_emit_char Tom Tromey
2022-02-16 17:47 ` Andrew Burgess
2022-02-16 20:40 ` Tom Tromey
2022-02-16 21:00 ` Tom Tromey
2022-02-16 13:55 ` [PATCH 12/18] Add a default encoding to generic_emit_char and generic_printstr Tom Tromey
2022-02-16 13:55 ` [PATCH 13/18] Change generic_emit_char to print the quotes Tom Tromey
2022-02-16 13:55 ` [PATCH 14/18] Use generic_emit_char in Rust Tom Tromey
2022-02-16 13:55 ` [PATCH 15/18] Use generic_emit_char in Ada Tom Tromey
2022-02-16 13:55 ` [PATCH 16/18] Use generic_emit_char in Modula-2 Tom Tromey
2022-02-16 13:55 ` [PATCH 17/18] Use generic_emit_char in Pascal Tom Tromey
2022-02-16 13:55 ` [PATCH 18/18] Simplify Fortran string printing Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216153941.GF2571@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).