From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 03/18] Remove c_emit_char
Date: Wed, 16 Feb 2022 15:40:19 +0000 [thread overview]
Message-ID: <20220216154019.GG2571@redhat.com> (raw)
In-Reply-To: <20220216135518.3162480-4-tom@tromey.com>
* Tom Tromey <tom@tromey.com> [2022-02-16 06:55:03 -0700]:
> This renames c_emit_char, removing a layer of indirection.
LGTM.
Thanks,
Andrew
> ---
> gdb/c-lang.c | 4 ++--
> gdb/c-lang.h | 3 ---
> gdb/language.c | 9 ---------
> 3 files changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/gdb/c-lang.c b/gdb/c-lang.c
> index 1f7cac7bef1..342109c94ef 100644
> --- a/gdb/c-lang.c
> +++ b/gdb/c-lang.c
> @@ -144,8 +144,8 @@ classify_type (struct type *elttype, struct gdbarch *gdbarch,
> for printing characters and strings is language specific. */
>
> void
> -c_emit_char (int c, struct type *type,
> - struct ui_file *stream, int quoter)
> +language_defn::emitchar (int c, struct type *type,
> + struct ui_file *stream, int quoter) const
> {
> const char *encoding;
>
> diff --git a/gdb/c-lang.h b/gdb/c-lang.h
> index 46e562df055..16c9b116393 100644
> --- a/gdb/c-lang.h
> +++ b/gdb/c-lang.h
> @@ -103,9 +103,6 @@ extern void c_printstr (struct ui_file * stream,
> extern void c_language_arch_info (struct gdbarch *gdbarch,
> struct language_arch_info *lai);
>
> -extern void c_emit_char (int c, struct type *type,
> - struct ui_file *stream, int quoter);
> -
> /* These are in c-typeprint.c: */
>
> extern void c_type_print_base (struct type *, struct ui_file *,
> diff --git a/gdb/language.c b/gdb/language.c
> index 69c73b0318e..931abcd3076 100644
> --- a/gdb/language.c
> +++ b/gdb/language.c
> @@ -635,15 +635,6 @@ language_defn::value_print_inner
>
> /* See language.h. */
>
> -void
> -language_defn::emitchar (int ch, struct type *chtype,
> - struct ui_file * stream, int quoter) const
> -{
> - c_emit_char (ch, chtype, stream, quoter);
> -}
> -
> -/* See language.h. */
> -
> void
> language_defn::printstr (struct ui_file *stream, struct type *elttype,
> const gdb_byte *string, unsigned int length,
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-02-16 15:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 13:55 [PATCH 00/18] Refactor character printing Tom Tromey
2022-02-16 13:55 ` [PATCH 01/18] Fix latent quote char bug in generic_printstr Tom Tromey
2022-02-16 15:38 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 02/18] Boolify need_escape in generic_emit_char Tom Tromey
2022-02-16 15:39 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 03/18] Remove c_emit_char Tom Tromey
2022-02-16 15:40 ` Andrew Burgess [this message]
2022-02-16 13:55 ` [PATCH 04/18] Remove c_printstr Tom Tromey
2022-02-16 15:46 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 05/18] Don't use wchar_printable in print_wchar Tom Tromey
2022-02-16 15:52 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 06/18] Fix a latent bug " Tom Tromey
2022-02-16 16:02 ` Andrew Burgess
2022-02-17 22:02 ` Tom Tromey
2022-02-16 13:55 ` [PATCH 07/18] Remove language_defn::emitchar Tom Tromey
2022-02-16 16:12 ` Andrew Burgess
2022-02-17 22:02 ` Tom Tromey
2022-02-16 13:55 ` [PATCH 08/18] Add gdb_iswcntrl Tom Tromey
2022-02-16 16:13 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 09/18] Include \0 in printable wide characters Tom Tromey
2022-02-16 17:19 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 10/18] Use a ui_file in print_wchar Tom Tromey
2022-02-16 17:25 ` Andrew Burgess
2022-02-16 13:55 ` [PATCH 11/18] Add an emitter callback to generic_printstr and generic_emit_char Tom Tromey
2022-02-16 17:47 ` Andrew Burgess
2022-02-16 20:40 ` Tom Tromey
2022-02-16 21:00 ` Tom Tromey
2022-02-16 13:55 ` [PATCH 12/18] Add a default encoding to generic_emit_char and generic_printstr Tom Tromey
2022-02-16 13:55 ` [PATCH 13/18] Change generic_emit_char to print the quotes Tom Tromey
2022-02-16 13:55 ` [PATCH 14/18] Use generic_emit_char in Rust Tom Tromey
2022-02-16 13:55 ` [PATCH 15/18] Use generic_emit_char in Ada Tom Tromey
2022-02-16 13:55 ` [PATCH 16/18] Use generic_emit_char in Modula-2 Tom Tromey
2022-02-16 13:55 ` [PATCH 17/18] Use generic_emit_char in Pascal Tom Tromey
2022-02-16 13:55 ` [PATCH 18/18] Simplify Fortran string printing Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216154019.GG2571@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).