public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [RFC PATCH 11/12] fbsd-nat: Add a low_prepare_to_resume virtual method.
Date: Mon, 28 Feb 2022 16:24:18 -0800	[thread overview]
Message-ID: <20220301002419.5122-12-jhb@FreeBSD.org> (raw)
In-Reply-To: <20220301002419.5122-1-jhb@FreeBSD.org>

This method can be overridden by architecture-specific targets to
perform additional work before a thread is resumed.
---
 gdb/fbsd-nat.c | 9 +++++++--
 gdb/fbsd-nat.h | 4 ++++
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index 2bc7937a38b..934fdbad6ef 100644
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -1138,6 +1138,8 @@ fbsd_nat_target::resume (ptid_t ptid, int step, enum gdb_signal signo)
 	    perror_with_name (request == PT_RESUME ?
 			      ("ptrace (PT_RESUME)") :
 			      ("ptrace (PT_SUSPEND)"));
+	  if (request == PT_RESUME)
+	    low_prepare_to_resume (tp);
 	}
     }
   else
@@ -1145,8 +1147,11 @@ fbsd_nat_target::resume (ptid_t ptid, int step, enum gdb_signal signo)
       /* If ptid is a wildcard, resume all matching threads (they won't run
 	 until the process is continued however).  */
       for (thread_info *tp : all_non_exited_threads (this, ptid))
-	if (ptrace (PT_RESUME, tp->ptid.lwp (), NULL, 0) == -1)
-	  perror_with_name (("ptrace (PT_RESUME)"));
+	{
+	  if (ptrace (PT_RESUME, tp->ptid.lwp (), NULL, 0) == -1)
+	    perror_with_name (("ptrace (PT_RESUME)"));
+	  low_prepare_to_resume (tp);
+	}
       ptid = inferior_ptid;
     }
 
diff --git a/gdb/fbsd-nat.h b/gdb/fbsd-nat.h
index 6028aebfccc..82f7ee47949 100644
--- a/gdb/fbsd-nat.h
+++ b/gdb/fbsd-nat.h
@@ -119,6 +119,10 @@ class fbsd_nat_target : public inf_ptrace_target
   virtual void low_delete_thread (thread_info *)
   {}
 
+  /* Hook to call prior to resuming a thread.  */
+  virtual void low_prepare_to_resume (thread_info *)
+  {}
+
 protected:
 
   void post_startup_inferior (ptid_t) override;
-- 
2.34.1


  parent reply	other threads:[~2022-03-01  0:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01  0:24 [RFC PATCH 00/12] FreeBSD/aarch64 hardware watchpoint support John Baldwin
2022-03-01  0:24 ` [RFC PATCH 01/12] Remove USE_SIGTRAP_SIGINFO condition for FreeBSD/x86 debug regs support John Baldwin
2022-03-01  0:24 ` [RFC PATCH 02/12] x86-nat: Use an unordered_map to store per-pid debug reg state John Baldwin
2022-03-03 19:20   ` Pedro Alves
2022-03-04  1:06     ` John Baldwin
2022-03-01  0:24 ` [RFC PATCH 03/12] x86-nat: Add x86_lookup_debug_reg_state John Baldwin
2022-03-01  0:24 ` [RFC PATCH 04/12] Add an x86_fbsd_nat_target mixin class for FreeBSD x86 native targets John Baldwin
2022-03-01  0:24 ` [RFC PATCH 05/12] fbsd-nat: Add a low_new_fork virtual method John Baldwin
2022-03-01  0:24 ` [RFC PATCH 06/12] x86-fbsd-nat: Copy debug register state on fork John Baldwin
2022-03-01  0:24 ` [RFC PATCH 07/12] nat: Split out platform-independent aarch64 debug register support John Baldwin
2022-03-03 19:26   ` Pedro Alves
2022-03-05  0:06     ` John Baldwin
2022-03-01  0:24 ` [RFC PATCH 08/12] aarch64: Add an aarch64_nat_target mixin class John Baldwin
2022-03-01  0:24 ` [RFC PATCH 09/12] fbsd-nat: Add helper routine to fetch siginfo_t for a ptid John Baldwin
2022-03-01  0:24 ` [RFC PATCH 10/12] fbsd-nat: Add a low_delete_thread virtual method John Baldwin
2022-03-01  0:24 ` John Baldwin [this message]
2022-03-01  0:24 ` [RFC PATCH 12/12] Add support for hardware breakpoints/watchpoints on FreeBSD/Aarch64 John Baldwin
2022-03-01  3:35   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301002419.5122-12-jhb@FreeBSD.org \
    --to=jhb@freebsd.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).