From: John Baldwin <jhb@FreeBSD.org>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [RFC PATCH 02/12] x86-nat: Use an unordered_map to store per-pid debug reg state.
Date: Thu, 3 Mar 2022 17:06:55 -0800 [thread overview]
Message-ID: <ef8a9daa-bb6d-5fc7-b8b8-22f40d65f20d@FreeBSD.org> (raw)
In-Reply-To: <d3d9ac96-4d92-a481-1139-3036f040534b@palves.net>
On 3/3/22 11:20 AM, Pedro Alves wrote:
> On 2022-03-01 00:24, John Baldwin wrote:
>> This replaces a manual linked list which used O(n) lookup and
>> removal.
>
>> +/* Hash table storing per-process data. We don't bind this to a
>> + per-inferior registry because of targets like x86 GNU/Linux that
>> + need to keep track of processes that aren't bound to any inferior
>> + (e.g., fork children, checkpoints). */
>> +
>> +static std::unordered_map<pid_t,
>> + gdb::unique_xmalloc_ptr<struct x86_debug_reg_state>>
>> +x86_debug_process_state;
>
> Why a map to pointer, instead of map to object, like:
>
> static std::unordered_map<pid_t, x86_debug_reg_state> x86_debug_process_state;
Mmmm, yes. I'm still more of a C programmer using C++ than a true C++
programmer. :)
--
John Baldwin
next prev parent reply other threads:[~2022-03-04 1:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 0:24 [RFC PATCH 00/12] FreeBSD/aarch64 hardware watchpoint support John Baldwin
2022-03-01 0:24 ` [RFC PATCH 01/12] Remove USE_SIGTRAP_SIGINFO condition for FreeBSD/x86 debug regs support John Baldwin
2022-03-01 0:24 ` [RFC PATCH 02/12] x86-nat: Use an unordered_map to store per-pid debug reg state John Baldwin
2022-03-03 19:20 ` Pedro Alves
2022-03-04 1:06 ` John Baldwin [this message]
2022-03-01 0:24 ` [RFC PATCH 03/12] x86-nat: Add x86_lookup_debug_reg_state John Baldwin
2022-03-01 0:24 ` [RFC PATCH 04/12] Add an x86_fbsd_nat_target mixin class for FreeBSD x86 native targets John Baldwin
2022-03-01 0:24 ` [RFC PATCH 05/12] fbsd-nat: Add a low_new_fork virtual method John Baldwin
2022-03-01 0:24 ` [RFC PATCH 06/12] x86-fbsd-nat: Copy debug register state on fork John Baldwin
2022-03-01 0:24 ` [RFC PATCH 07/12] nat: Split out platform-independent aarch64 debug register support John Baldwin
2022-03-03 19:26 ` Pedro Alves
2022-03-05 0:06 ` John Baldwin
2022-03-01 0:24 ` [RFC PATCH 08/12] aarch64: Add an aarch64_nat_target mixin class John Baldwin
2022-03-01 0:24 ` [RFC PATCH 09/12] fbsd-nat: Add helper routine to fetch siginfo_t for a ptid John Baldwin
2022-03-01 0:24 ` [RFC PATCH 10/12] fbsd-nat: Add a low_delete_thread virtual method John Baldwin
2022-03-01 0:24 ` [RFC PATCH 11/12] fbsd-nat: Add a low_prepare_to_resume " John Baldwin
2022-03-01 0:24 ` [RFC PATCH 12/12] Add support for hardware breakpoints/watchpoints on FreeBSD/Aarch64 John Baldwin
2022-03-01 3:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef8a9daa-bb6d-5fc7-b8b8-22f40d65f20d@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).