[PATCH] Remove "Ada Settings" node from the manual

[PATCH] Remove "Ada Settings" node from the manual

[Tom Tromey]

A while back, I sent a patch to unify the Ada varsize-limit setting
with the more generic max-value-size:

https://sourceware.org/pipermail/gdb-patches/2021-September/182004.html

However, it turns out I somehow neglected to send part of the patch.
Internally, I also removed the "Ada Settings" node from the manual, as
it only documents the obsolete setting.

This patch removes this text.
---
 gdb/doc/gdb.texinfo | 32 --------------------------------
 1 file changed, 32 deletions(-)

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index d216fa1d529..1c0e89fc234 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -18014,7 +18014,6 @@ to be difficult.
 * Ada Tasks and Core Files::    Tasking Support when Debugging Core Files
 * Ravenscar Profile::           Tasking Support when using the Ravenscar
                                    Profile
-* Ada Settings::                New settable GDB parameters for Ada.
 * Ada Source Character Set::    Character set of Ada source files.
 * Ada Glitches::                Known peculiarities of Ada mode.
 @end menu
@@ -18751,37 +18750,6 @@ it isn't currently possible to single-step through the runtime
 initialization sequence.  If you need to debug this code, you should
 use @code{set ravenscar task-switching off}.
 
-@node Ada Settings
-@subsubsection Ada Settings
-@cindex Ada settings
-
-@table @code
-@kindex set varsize-limit
-@item set varsize-limit @var{size}
-Prevent @value{GDBN} from attempting to evaluate objects whose size
-is above the given limit (@var{size}) when those sizes are computed
-from run-time quantities.  This is typically the case when the object
-has a variable size, such as an array whose bounds are not known at
-compile time for example.  Setting @var{size} to @code{unlimited}
-removes the size limitation.  By default, the limit is about 65KB.
-
-The purpose of having such a limit is to prevent @value{GDBN} from
-trying to grab enormous chunks of virtual memory when asked to evaluate
-a quantity whose bounds have been corrupted or have not yet been fully
-initialized.  The limit applies to the results of some subexpressions
-as well as to complete expressions.  For example, an expression denoting
-a simple integer component, such as @code{x.y.z}, may fail if the size of
-@code{x.y} is variable and exceeds @code{size}.  On the other hand,
-@value{GDBN} is sometimes clever; the expression @code{A(i)}, where
-@code{A} is an array variable with non-constant size, will generally
-succeed regardless of the bounds on @code{A}, as long as the component
-size is less than @var{size}.
-
-@kindex show varsize-limit
-@item show varsize-limit
-Show the limit on types whose size is determined by run-time quantities.
-@end table
-
 @node Ada Source Character Set
 @subsubsection Ada Source Character Set
 @cindex Ada, source character set
-- 
2.34.1

Re: [PATCH] Remove "Ada Settings" node from the manual

[Tom Tromey]

>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> A while back, I sent a patch to unify the Ada varsize-limit setting
Tom> with the more generic max-value-size:

Tom> https://sourceware.org/pipermail/gdb-patches/2021-September/182004.html

Tom> However, it turns out I somehow neglected to send part of the patch.
Tom> Internally, I also removed the "Ada Settings" node from the manual, as
Tom> it only documents the obsolete setting.

Tom> This patch removes this text.

Ping.

Tom

Re: [PATCH] Remove "Ada Settings" node from the manual

[Eli Zaretskii]

> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>, eliz@gnu.org
> Date: Fri, 08 Apr 2022 07:23:56 -0600
> 
> >>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> A while back, I sent a patch to unify the Ada varsize-limit setting
> Tom> with the more generic max-value-size:
> 
> Tom> https://sourceware.org/pipermail/gdb-patches/2021-September/182004.html
> 
> Tom> However, it turns out I somehow neglected to send part of the patch.
> Tom> Internally, I also removed the "Ada Settings" node from the manual, as
> Tom> it only documents the obsolete setting.
> 
> Tom> This patch removes this text.
> 
> Ping.

Removing some material from the manual doesn't need my approval, it is
enough to get agreement from people who are responsible for the
respective parts in GDB.

Thanks.

Re: [PATCH] Remove "Ada Settings" node from the manual

[Tom Tromey]

Tom> A while back, I sent a patch to unify the Ada varsize-limit setting
Tom> with the more generic max-value-size:
Tom> https://sourceware.org/pipermail/gdb-patches/2021-September/182004.html
Tom> However, it turns out I somehow neglected to send part of the patch.
Tom> Internally, I also removed the "Ada Settings" node from the manual, as
Tom> it only documents the obsolete setting.
Tom> This patch removes this text.

>> Ping.

Eli> Removing some material from the manual doesn't need my approval, it is
Eli> enough to get agreement from people who are responsible for the
Eli> respective parts in GDB.

Alright, thanks.
I'm also going to push this to the gdb-12 branch, as that branch also
has the changes in question.

Tom