public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v5 2/2] gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp
Date: Fri, 18 Mar 2022 13:07:23 -0700	[thread overview]
Message-ID: <20220318130723.469573af@f35-zws-1> (raw)
In-Reply-To: <1645584316-5375-3-git-send-email-yangtiezhu@loongson.cn>

I'm seeing a problem with this commit:

1dbf27133db gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp

:

FAIL: gdb.base/run-after-attach.exp: can spawn for attach

Here's the relevant portion of the log file:

Running /mesquite2/sourceware-git/f35-master/bld/../../worktree-master/gdb/testsuite/gdb.base/run-after-attach.exp ...
Executing on host: gcc    -fdiagnostics-color=never -c -o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/ccopts184212.o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/ccopts184212.c    (timeout = 300)
builtin_spawn -ignore SIGHUP gcc -fdiagnostics-color=never -c -o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/ccopts184212.o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/ccopts184212.c
get_compiler_info: gcc-11-2-1
Executing on host: gcc  -fno-stack-protector /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.c   -fdiagnostics-color=never -w -g  -lm  -o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.x    (timeout = 300)
builtin_spawn -ignore SIGHUP gcc -fno-stack-protector /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.c -fdiagnostics-color=never -w -g -lm -o /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.x
builtin_spawn /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/can_spawn_for_attach-184212.x
builtin_spawn /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/../../gdb/gdb -nw -nx -data-directory /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/../data-directory -iex set height 0 -iex set width 0
GNU gdb (GDB) 12.0.50.20220318-git
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word".
(gdb) set height 0
(gdb) set width 0
(gdb) attach 184257
Attaching to process 184257
Reading symbols from /mesquite2/sourceware-git/f35-master/bld/gdb/testsuite/temp/184212/.nfs0000000002713c210000000a...
Reading symbols from /lib64/libm.so.6...
Reading symbols from /usr/lib/debug/usr/lib64/libm.so.6-2.34-28.fc35.x86_64.debug...
Reading symbols from /lib64/libc.so.6...
Reading symbols from /usr/lib/debug/usr/lib64/libc.so.6-2.34-28.fc35.x86_64.debug...
Reading symbols from /lib64/ld-linux-x86-64.so.2...
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
__GI___clock_nanosleep (clock_id=clock_id@entry=0, flags=flags@entry=0, req=req@entry=0x7ffc4d0e2210, rem=rem@entry=0x7ffc4d0e2210) at ../sysdeps/unix/sysv/linux/clock_nanosleep.c:71
71	  return -r;
(gdb) FAIL: gdb.base/run-after-attach.exp: can spawn for attach

The attach appears to have worked.  I think that this case was
simply overlooked in the recent changes to can_spawn_for_attach.

Kevin



  parent reply	other threads:[~2022-03-18 20:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23  2:45 [PATCH v5 0/2] Modify can_spawn_for_attach Tiezhu Yang
2022-02-23  2:45 ` [PATCH v5 1/2] gdb: testsuite: print explicit test result in can_spawn_for_attach Tiezhu Yang
2022-02-23  2:45 ` [PATCH v5 2/2] gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp Tiezhu Yang
2022-03-03 18:45   ` Pedro Alves
2022-03-18 20:07   ` Kevin Buettner [this message]
2022-03-18 20:43     ` Kevin Buettner
2022-02-28  6:59 ` [PATCH v5 0/2] Modify can_spawn_for_attach Tiezhu Yang
2022-02-28 14:36   ` Simon Marchi
2022-03-01 14:12     ` Simon Marchi
2022-03-02  6:42       ` Tiezhu Yang
2022-03-03 15:46         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220318130723.469573af@f35-zws-1 \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).