From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tiezhu Yang <yangtiezhu@loongson.cn>, gdb-patches@sourceware.org
Subject: Re: [PATCH v5 0/2] Modify can_spawn_for_attach
Date: Tue, 1 Mar 2022 09:12:44 -0500 [thread overview]
Message-ID: <26ffd2e4-4aab-4367-96fb-bb8330b8eff8@polymtl.ca> (raw)
In-Reply-To: <52930d69-2534-6c6d-e716-e256020bc4a2@polymtl.ca>
On 2022-02-28 09:36, Simon Marchi via Gdb-patches wrote:
> On 2022-02-28 01:59, Tiezhu Yang wrote:
>>
>>
>> On 02/23/2022 10:45 AM, Tiezhu Yang wrote:
>>> v5:
>>> -- Use "unsupported" instead of "untested" in patch #1,
>>> suggested by Simon Marchi, thank you.
>>>
>>> v4:
>>> -- Add patch #1 to print explicit test result for some test.
>>> -- Modify patch #2 suggested by Simon Marchi, thank you.
>>>
>>> Tiezhu Yang (2):
>>> gdb: testsuite: print explicit test result in can_spawn_for_attach
>>> gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp
>>>
>>> gdb/testsuite/lib/gdb.exp | 46 +++++++++++++++++++++++++++++++++++++++-------
>>> 1 file changed, 39 insertions(+), 7 deletions(-)
>>>
>>
>> Hi,
>>
>> I modified the patches as you suggested.
>> Any more comments?
>> Can I push this patchset to the master?
>
> Yeah, please go ahead, thanks.
>
> Simon
Actually, this causes the following test failures:
FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt)
Can you please take a look?
Thanks,
Simon
next prev parent reply other threads:[~2022-03-01 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 2:45 Tiezhu Yang
2022-02-23 2:45 ` [PATCH v5 1/2] gdb: testsuite: print explicit test result in can_spawn_for_attach Tiezhu Yang
2022-02-23 2:45 ` [PATCH v5 2/2] gdb: testsuite: fix wrong expected result in attach-pie-noexec.exp Tiezhu Yang
2022-03-03 18:45 ` Pedro Alves
2022-03-18 20:07 ` Kevin Buettner
2022-03-18 20:43 ` Kevin Buettner
2022-02-28 6:59 ` [PATCH v5 0/2] Modify can_spawn_for_attach Tiezhu Yang
2022-02-28 14:36 ` Simon Marchi
2022-03-01 14:12 ` Simon Marchi [this message]
2022-03-02 6:42 ` Tiezhu Yang
2022-03-03 15:46 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26ffd2e4-4aab-4367-96fb-bb8330b8eff8@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).