From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 1/2] gdb: remove some unused buildsym-legacy functions
Date: Mon, 28 Mar 2022 18:17:16 -0400 [thread overview]
Message-ID: <20220328221717.2896842-1-simon.marchi@efficios.com> (raw)
Pretty much self-explanatory.
Change-Id: I5b658d017cd891ecdd1df61075eacb0f44316935
---
gdb/buildsym-legacy.c | 89 -------------------------------------------
gdb/buildsym-legacy.h | 36 -----------------
2 files changed, 125 deletions(-)
diff --git a/gdb/buildsym-legacy.c b/gdb/buildsym-legacy.c
index 7659f53cbe0..cfafcc38640 100644
--- a/gdb/buildsym-legacy.c
+++ b/gdb/buildsym-legacy.c
@@ -79,33 +79,6 @@ get_last_source_start_addr ()
/* See buildsym.h. */
-struct using_direct **
-get_local_using_directives ()
-{
- gdb_assert (buildsym_compunit != nullptr);
- return buildsym_compunit->get_local_using_directives ();
-}
-
-/* See buildsym.h. */
-
-void
-set_local_using_directives (struct using_direct *new_local)
-{
- gdb_assert (buildsym_compunit != nullptr);
- buildsym_compunit->set_local_using_directives (new_local);
-}
-
-/* See buildsym.h. */
-
-struct using_direct **
-get_global_using_directives ()
-{
- gdb_assert (buildsym_compunit != nullptr);
- return buildsym_compunit->get_global_using_directives ();
-}
-
-/* See buildsym.h. */
-
bool
outermost_context_p ()
{
@@ -115,15 +88,6 @@ outermost_context_p ()
/* See buildsym.h. */
-struct context_stack *
-get_current_context_stack ()
-{
- gdb_assert (buildsym_compunit != nullptr);
- return buildsym_compunit->get_current_context_stack ();
-}
-
-/* See buildsym.h. */
-
int
get_context_stack_depth ()
{
@@ -240,14 +204,6 @@ finish_block (struct symbol *symbol, struct pending_block *old_blocks,
start, end);
}
-void
-record_block_range (struct block *block, CORE_ADDR start,
- CORE_ADDR end_inclusive)
-{
- gdb_assert (buildsym_compunit != nullptr);
- buildsym_compunit->record_block_range (block, start, end_inclusive);
-}
-
void
record_line (struct subfile *subfile, int line, CORE_ADDR pc)
{
@@ -283,51 +239,6 @@ start_symtab (struct objfile *objfile, const char *name, const char *comp_dir,
return buildsym_compunit->get_compunit_symtab ();
}
-/* Restart compilation for a symtab.
- CUST is the result of end_expandable_symtab.
- NAME, START_ADDR are the source file we are resuming with.
-
- This is used when a symtab is built from multiple sources.
- The symtab is first built with start_symtab/end_expandable_symtab
- and then for each additional piece call restart_symtab/augment_*_symtab.
- Note: At the moment there is only augment_type_symtab. */
-
-void
-restart_symtab (struct compunit_symtab *cust,
- const char *name, CORE_ADDR start_addr)
-{
- /* These should have been reset either by successful completion of building
- a symtab, or by the scoped_free_pendings destructor. */
- gdb_assert (buildsym_compunit == nullptr);
-
- buildsym_compunit
- = new struct buildsym_compunit (cust->objfile (),
- name,
- cust->dirname (),
- compunit_language (cust),
- start_addr,
- cust);
-}
-
-/* See buildsym.h. */
-
-struct compunit_symtab *
-buildsym_compunit_symtab (void)
-{
- gdb_assert (buildsym_compunit != NULL);
-
- return buildsym_compunit->get_compunit_symtab ();
-}
-
-/* See buildsym.h. */
-
-struct macro_table *
-get_macro_table (void)
-{
- gdb_assert (buildsym_compunit != NULL);
- return buildsym_compunit->get_macro_table ();
-}
-
/* At end of reading syms, or in case of quit, ensure everything
associated with building symtabs is freed.
diff --git a/gdb/buildsym-legacy.h b/gdb/buildsym-legacy.h
index 9393aff4cee..b8b5caf0763 100644
--- a/gdb/buildsym-legacy.h
+++ b/gdb/buildsym-legacy.h
@@ -62,9 +62,6 @@ extern struct block *finish_block (struct symbol *symbol,
CORE_ADDR start,
CORE_ADDR end);
-extern void record_block_range (struct block *,
- CORE_ADDR start, CORE_ADDR end_inclusive);
-
extern void start_subfile (const char *name);
extern void patch_subfile_names (struct subfile *subfile, const char *name);
@@ -87,9 +84,6 @@ extern struct compunit_symtab *start_symtab (struct objfile *objfile,
CORE_ADDR start_addr,
enum language language);
-extern void restart_symtab (struct compunit_symtab *cust,
- const char *name, CORE_ADDR start_addr);
-
/* Record the name of the debug format in the current pending symbol
table. FORMAT must be a string with a lifetime at least as long as
the symtab's objfile. */
@@ -111,19 +105,6 @@ extern void set_last_source_file (const char *name);
extern const char *get_last_source_file (void);
-/* Return the compunit symtab object.
- It is only valid to call this between calls to start_symtab and the
- end_symtab* functions. */
-
-extern struct compunit_symtab *buildsym_compunit_symtab (void);
-
-/* Return the macro table.
- Initialize it if this is the first use.
- It is only valid to call this between calls to start_symtab and the
- end_symtab* functions. */
-
-extern struct macro_table *get_macro_table (void);
-
/* Set the last source start address. Can only be used between
start_symtab and end_symtab* calls. */
@@ -134,27 +115,10 @@ extern void set_last_source_start_addr (CORE_ADDR addr);
extern CORE_ADDR get_last_source_start_addr ();
-/* Return the local using directives. */
-
-extern struct using_direct **get_local_using_directives ();
-
-/* Set the list of local using directives. */
-
-extern void set_local_using_directives (struct using_direct *new_local);
-
-/* Return the global using directives. */
-
-extern struct using_direct **get_global_using_directives ();
-
/* True if the context stack is empty. */
extern bool outermost_context_p ();
-/* Return the top of the context stack, or nullptr if there is an
- entry. */
-
-extern struct context_stack *get_current_context_stack ();
-
/* Return the context stack depth. */
extern int get_context_stack_depth ();
--
2.35.1
next reply other threads:[~2022-03-28 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 22:17 Simon Marchi [this message]
2022-03-28 22:17 ` [PATCH 2/2] gdb: rename start_symtab/end_symtab to start_compunit_symtab/end_compunit_symtab Simon Marchi
2022-04-04 16:31 ` Tom Tromey
2022-04-04 16:58 ` Simon Marchi
2022-04-04 16:30 ` [PATCH 1/2] gdb: remove some unused buildsym-legacy functions Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328221717.2896842-1-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).