From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] gdb: rename start_symtab/end_symtab to start_compunit_symtab/end_compunit_symtab
Date: Mon, 4 Apr 2022 12:58:54 -0400 [thread overview]
Message-ID: <9109004e-c815-64ea-90ae-f69daa341994@efficios.com> (raw)
In-Reply-To: <87lewkkdyg.fsf@tromey.com>
On 2022-04-04 12:31, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> It's a bit confusing because we have both "compunit_symtab" and "symtab"
> Simon> types, and many methods and functions containing "start_symtab" or
> Simon> "end_symtab", which actually deal with compunit_symtabs. I believe this
> Simon> comes from the time before compunit_symtab was introduced, where
> Simon> symtab did the job of both.
>
> Simon> Rename everything I found containing start_symtab or end_symtab to use
> Simon> start_compunit_symtab or end_compunit_symtab.
>
> Seems reasonable to me.
>
> Tom
Thanks, pushed both patches.
Simon
next prev parent reply other threads:[~2022-04-04 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 22:17 [PATCH 1/2] gdb: remove some unused buildsym-legacy functions Simon Marchi
2022-03-28 22:17 ` [PATCH 2/2] gdb: rename start_symtab/end_symtab to start_compunit_symtab/end_compunit_symtab Simon Marchi
2022-04-04 16:31 ` Tom Tromey
2022-04-04 16:58 ` Simon Marchi [this message]
2022-04-04 16:30 ` [PATCH 1/2] gdb: remove some unused buildsym-legacy functions Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9109004e-c815-64ea-90ae-f69daa341994@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).