public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 1/2] gdb/testsuite/dwarf: remove two unused variables
@ 2022-04-06 15:43 Simon Marchi
  2022-04-06 15:43 ` [PATCH 2/2] gdb/testsuite/dwarf: simplify line number program syntax Simon Marchi
  2022-04-07  1:53 ` [PATCH 1/2] gdb/testsuite/dwarf: remove two unused variables Simon Marchi
  0 siblings, 2 replies; 4+ messages in thread
From: Simon Marchi @ 2022-04-06 15:43 UTC (permalink / raw)
  To: gdb-patches

These variables seem to be unused, remove them.

Change-Id: I7d613d9d35735930ee78b2c348943c73a702afbb
---
 gdb/testsuite/lib/dwarf.exp | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index ed7ad3831809..3d88003ccb09 100644
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -569,12 +569,6 @@ namespace eval Dwarf {
     # Current .debug_line unit count.
     variable _line_count
 
-    # Whether a file_name entry was seen.
-    variable _line_saw_file
-
-    # Whether a line table program has been seen.
-    variable _line_saw_program
-
     # A Label for line table header generation.
     variable _line_header_end_label
 
@@ -2178,11 +2172,9 @@ namespace eval Dwarf {
 
     proc lines {options label body} {
 	variable _line_count
-	variable _line_saw_file
 	variable _line_include_dirs
 	variable _line_file_names
 	variable _line_header_finalized
-	variable _line_saw_program
 	variable _line_header_end_label
 	variable _line_unit_version
 	variable _line_is_64
@@ -2192,8 +2184,6 @@ namespace eval Dwarf {
 	set _line_is_64 0
 	set _line_unit_version 4
 	set _unit_addr_size default
-	set _line_saw_program 0
-	set _line_saw_file 0
 	set _line_include_dirs {}
 	set _line_file_names {}
 	set _line_header_finalized 0
@@ -2295,9 +2285,6 @@ namespace eval Dwarf {
 	proc file_name {filename diridx} {
 	    variable _line_file_names
 	    lappend _line_file_names $filename $diridx
-
-	    variable _line_saw_file 1
-	    set _line_saw_file 1
 	}
 
 	proc _line_finalize_header {} {
@@ -2424,11 +2411,9 @@ namespace eval Dwarf {
 	}
 
 	proc program {statements} {
-	    variable _line_saw_program
 	    variable _line_header_end_label
 	    variable _line
 
-	    set _line_saw_program 1
 
 	    set _line 1
 
@@ -2872,8 +2857,6 @@ namespace eval Dwarf {
 	variable _strings
 	variable _cu_count
 	variable _line_count
-	variable _line_saw_file
-	variable _line_saw_program
 	variable _line_header_end_label
 	variable _debug_ranges_64_bit
 	variable _debug_addr_index
@@ -2891,8 +2874,6 @@ namespace eval Dwarf {
 	_empty_array _strings
 
 	set _line_count 0
-	set _line_saw_file 0
-	set _line_saw_program 0
 	set _debug_ranges_64_bit [is_64_target]
 
 	set _debug_addr_index 0

base-commit: 477904ca751c50d243ee3cba3f12cf75e8ba12b3
-- 
2.35.1


^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH 1/2] gdb/testsuite/dwarf: remove two unused variables
@ 2022-03-24 16:18 Simon Marchi
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Marchi @ 2022-03-24 16:18 UTC (permalink / raw)
  To: gdb-patches

From: Simon Marchi <simon.marchi@polymtl.ca>

These variables seem to be unused, remove them.

Change-Id: I7d613d9d35735930ee78b2c348943c73a702afbb
---
 gdb/testsuite/lib/dwarf.exp | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index 6e8b1ccbe7f3..f8211c3cc1a2 100644
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -569,12 +569,6 @@ namespace eval Dwarf {
     # Current .debug_line unit count.
     variable _line_count
 
-    # Whether a file_name entry was seen.
-    variable _line_saw_file
-
-    # Whether a line table program has been seen.
-    variable _line_saw_program
-
     # A Label for line table header generation.
     variable _line_header_end_label
 
@@ -2178,11 +2172,9 @@ namespace eval Dwarf {
 
     proc lines {options label body} {
 	variable _line_count
-	variable _line_saw_file
 	variable _line_include_dirs
 	variable _line_file_names
 	variable _line_header_finalized
-	variable _line_saw_program
 	variable _line_header_end_label
 	variable _line_unit_version
 	variable _line_is_64
@@ -2192,8 +2184,6 @@ namespace eval Dwarf {
 	set _line_is_64 0
 	set _line_unit_version 4
 	set _unit_addr_size default
-	set _line_saw_program 0
-	set _line_saw_file 0
 	set _line_include_dirs {}
 	set _line_file_names {}
 	set _line_header_finalized 0
@@ -2295,9 +2285,6 @@ namespace eval Dwarf {
 	proc file_name {filename diridx} {
 	    variable _line_file_names
 	    lappend _line_file_names $filename $diridx
-
-	    variable _line_saw_file 1
-	    set _line_saw_file 1
 	}
 
 	proc _line_finalize_header {} {
@@ -2424,11 +2411,9 @@ namespace eval Dwarf {
 	}
 
 	proc program {statements} {
-	    variable _line_saw_program
 	    variable _line_header_end_label
 	    variable _line
 
-	    set _line_saw_program 1
 
 	    set _line 1
 
@@ -2868,8 +2853,6 @@ namespace eval Dwarf {
 	variable _strings
 	variable _cu_count
 	variable _line_count
-	variable _line_saw_file
-	variable _line_saw_program
 	variable _line_header_end_label
 	variable _debug_ranges_64_bit
 	variable _debug_addr_index
@@ -2887,8 +2870,6 @@ namespace eval Dwarf {
 	_empty_array _strings
 
 	set _line_count 0
-	set _line_saw_file 0
-	set _line_saw_program 0
 	set _debug_ranges_64_bit [is_64_target]
 
 	set _debug_addr_index 0
-- 
2.26.2


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-07  1:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-06 15:43 [PATCH 1/2] gdb/testsuite/dwarf: remove two unused variables Simon Marchi
2022-04-06 15:43 ` [PATCH 2/2] gdb/testsuite/dwarf: simplify line number program syntax Simon Marchi
2022-04-07  1:53 ` [PATCH 1/2] gdb/testsuite/dwarf: remove two unused variables Simon Marchi
  -- strict thread matches above, loose matches on Subject: below --
2022-03-24 16:18 Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).