From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Tom Tromey <tromey@adacore.com>,
Andrew Burgess <aburgess@redhat.com>,
Pedro Alves <pedro@palves.net>
Cc: Andreas Arnez <arnez@linux.ibm.com>,
gdb-patches@sourceware.org, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH 1/5] gdbsupport: Introduce obstack_newvec
Date: Thu, 2 Jun 2022 15:35:42 +0200 [thread overview]
Message-ID: <20220602133546.2948282-2-iii@linux.ibm.com> (raw)
In-Reply-To: <20220602133546.2948282-1-iii@linux.ibm.com>
obstack_calloc() allocates multiple objects, but doesn't call their
constructors. obstack_new() allocates a single object and calls its
constructor. Introduce a new function that does both.
---
gdbsupport/gdb_obstack.h | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/gdbsupport/gdb_obstack.h b/gdbsupport/gdb_obstack.h
index 5e870cb7981..201ed99216f 100644
--- a/gdbsupport/gdb_obstack.h
+++ b/gdbsupport/gdb_obstack.h
@@ -59,6 +59,32 @@ obstack_new (struct obstack *ob, Args&&... args)
return object;
}
+/* Allocate NUMBER objects on OB and call their default constructors. Note
+ that obstack_free() won't call their destructors: this has to be done
+ manually. */
+
+template <typename T>
+static inline T *
+obstack_newvec (obstack *ob, size_t number)
+{
+ T *objects = static_cast<T *> (obstack_alloc (ob, number * sizeof (T)));
+ for (size_t i = 0; i < number; i++)
+ {
+ try
+ {
+ new (objects + i) T ();
+ }
+ catch (...)
+ {
+ for (size_t j = 0; j < i; j++)
+ (objects + j)->~T ();
+ obstack_free (ob, objects);
+ throw;
+ };
+ }
+ return objects;
+}
+
/* Unless explicitly specified, GDB obstacks always use xmalloc() and
xfree(). */
/* Note: ezannoni 2004-02-09: One could also specify the allocation
--
2.35.3
next prev parent reply other threads:[~2022-06-02 13:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 13:35 [PATCH 0/5] gdb: Store section map in an interval tree Ilya Leoshkevich
2022-06-02 13:35 ` Ilya Leoshkevich [this message]
2022-06-02 14:31 ` [PATCH 1/5] gdbsupport: Introduce obstack_newvec Tom Tromey
2022-06-02 14:33 ` Ilya Leoshkevich
2022-06-02 13:35 ` [PATCH 2/5] gdbsupport: Introduce interval_tree Ilya Leoshkevich
2022-06-02 14:12 ` Pedro Alves
2022-06-02 14:17 ` Ilya Leoshkevich
2022-06-02 14:12 ` Pedro Alves
2022-06-02 14:37 ` Pedro Alves
2022-06-02 15:09 ` Ilya Leoshkevich
2022-06-02 18:04 ` Tom Tromey
2022-06-02 13:35 ` [PATCH 3/5] gdbsupport: Add interval_tree unit tests Ilya Leoshkevich
2022-06-02 13:35 ` [PATCH 4/5] gdbsupport: Add interval_tree fuzzing harness Ilya Leoshkevich
2022-06-02 13:35 ` [PATCH 5/5] gdb: Optimize section map Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602133546.2948282-2-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=aburgess@redhat.com \
--cc=arnez@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).