From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <pedro@palves.net>
Cc: Ilya Leoshkevich <iii@linux.ibm.com>,
Tom Tromey <tromey@adacore.com>,
Andrew Burgess <aburgess@redhat.com>,
Andreas Arnez <arnez@linux.ibm.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] gdbsupport: Introduce interval_tree
Date: Thu, 02 Jun 2022 12:04:48 -0600 [thread overview]
Message-ID: <87fskn2b7j.fsf@tromey.com> (raw)
In-Reply-To: <52e0e168-3ad4-df0e-5b46-2856e82b5d47@palves.net> (Pedro Alves's message of "Thu, 2 Jun 2022 15:37:14 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> As you see, I was using an addrmap for this (gdb/addrmap.h),
Pedro> which is a data structure we already have. I wonder whether the
Pedro> new data structure is really needed. That's a question I was
Pedro> going to raise anyhow, until I remembered I had once already
Pedro> attempted it (and seen that it works).
I was going to ask this as well, though it's worth noting that addrmap
isn't really general purpose in that the ranges have to be CORE_ADDR,
and also you can't remove entries. The former is something I hacked
around in the new DWARF scanner -- where a real template class might be
cleaner.
Tom
next prev parent reply other threads:[~2022-06-02 18:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 13:35 [PATCH 0/5] gdb: Store section map in an interval tree Ilya Leoshkevich
2022-06-02 13:35 ` [PATCH 1/5] gdbsupport: Introduce obstack_newvec Ilya Leoshkevich
2022-06-02 14:31 ` Tom Tromey
2022-06-02 14:33 ` Ilya Leoshkevich
2022-06-02 13:35 ` [PATCH 2/5] gdbsupport: Introduce interval_tree Ilya Leoshkevich
2022-06-02 14:12 ` Pedro Alves
2022-06-02 14:17 ` Ilya Leoshkevich
2022-06-02 14:12 ` Pedro Alves
2022-06-02 14:37 ` Pedro Alves
2022-06-02 15:09 ` Ilya Leoshkevich
2022-06-02 18:04 ` Tom Tromey [this message]
2022-06-02 13:35 ` [PATCH 3/5] gdbsupport: Add interval_tree unit tests Ilya Leoshkevich
2022-06-02 13:35 ` [PATCH 4/5] gdbsupport: Add interval_tree fuzzing harness Ilya Leoshkevich
2022-06-02 13:35 ` [PATCH 5/5] gdb: Optimize section map Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fskn2b7j.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=aburgess@redhat.com \
--cc=arnez@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=iii@linux.ibm.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).