public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 3/4] testsuite, fortran: adapt tests for ifort's 'start' behavior
Date: Fri, 10 Jun 2022 17:44:59 +0200	[thread overview]
Message-ID: <20220610154500.374897-4-nils-christian.kempke@intel.com> (raw)
In-Reply-To: <20220610154500.374897-1-nils-christian.kempke@intel.com>

The modified tests array-slices-bad.exp and vla-type.exp both set a
breakpoint at the first real statement in the respective executables.

Normally, the expected behavior of fortran_runto_main for these would be
the stopping of the debugger at exactly the first statment in the code.

Strangely, neither gfortran nor ifx seem to do this for these tests.
Instead, issuing 'start' in ifx (for either of the 2 tests) lets GDB
stop at the 'program ...' line and gfortran stops at a variable
declaration line.  E.g. for vla-type it stops at

  41        type(five)               :: fivearr (2)

So, actually, ifort's behavior can be considered to be a bit more
'correct' here.  The changes skip running to the first breakpoint when
compiling with ifort, which improves test performance for ifort.  A
similar skip already existed for flang in vla-type.exp.
---
 gdb/testsuite/gdb.fortran/array-slices-bad.exp | 5 ++++-
 gdb/testsuite/gdb.fortran/vla-type.exp         | 5 +++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.fortran/array-slices-bad.exp b/gdb/testsuite/gdb.fortran/array-slices-bad.exp
index b832fea292..514f208577 100644
--- a/gdb/testsuite/gdb.fortran/array-slices-bad.exp
+++ b/gdb/testsuite/gdb.fortran/array-slices-bad.exp
@@ -40,7 +40,10 @@ gdb_breakpoint [gdb_get_line_number "First Breakpoint"]
 gdb_breakpoint [gdb_get_line_number "Second Breakpoint"]
 gdb_breakpoint [gdb_get_line_number "Final Breakpoint"]
 
-gdb_continue_to_breakpoint "First Breakpoint"
+# Ifort is already at this line after runto_main.
+if { ![test_compiler_info {ifort-*} f90] } {
+    gdb_continue_to_breakpoint "First Breakpoint"
+}
 
 # Access not yet allocated array.
 gdb_test "print other" " = <not allocated>"
diff --git a/gdb/testsuite/gdb.fortran/vla-type.exp b/gdb/testsuite/gdb.fortran/vla-type.exp
index fc8494fe36..884e0dc113 100755
--- a/gdb/testsuite/gdb.fortran/vla-type.exp
+++ b/gdb/testsuite/gdb.fortran/vla-type.exp
@@ -32,8 +32,9 @@ set int [fortran_int4]
 
 # Check if not allocated VLA in type does not break
 # the debugger when accessing it.
-# break main for Flang compiler already breaks here
-if { ![test_compiler_info {flang-*} f90] } {
+# Run to main for for Flang and ifort compilers already breaks here.
+if { ![test_compiler_info {flang-*} f90]
+     && ![test_compiler_info {ifort-*} f90]} {
     gdb_breakpoint [gdb_get_line_number "before-allocated"]
     gdb_continue_to_breakpoint "before-allocated"
 }
-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  parent reply	other threads:[~2022-06-10 15:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 15:44 [PATCH 0/4] Adapt Fortran testsuite for ifort Nils-Christian Kempke
2022-06-10 15:44 ` [PATCH 1/4] testsuite, fortran: make mixed-lang-stack less compiler dependent Nils-Christian Kempke
2022-06-10 15:44 ` [PATCH 2/4] testsuite, fortran: Remove self assignment non-statements Nils-Christian Kempke
2022-06-10 15:44 ` Nils-Christian Kempke [this message]
2022-08-30 19:51   ` [PATCH 3/4] testsuite, fortran: adapt tests for ifort's 'start' behavior Tom Tromey
2022-08-31  9:32     ` Kempke, Nils-Christian
2022-08-31 17:22       ` Tom Tromey
2022-06-10 15:45 ` [PATCH 4/4] testsuite, fortran: make kfail gfortran specific Nils-Christian Kempke
2022-07-04 15:59 ` [PING 2][PATCH 0/4] Adapt Fortran testsuite for ifort Kempke, Nils-Christian
2022-07-12 12:55   ` [PING 3][PATCH " Kempke, Nils-Christian
2022-07-27  5:14     ` [PING 4][PATCH " Kempke, Nils-Christian
2022-08-08 12:53       ` Kempke, Nils-Christian
2022-08-23 14:43         ` [PING 5][PATCH " Kempke, Nils-Christian
2022-08-30 14:47           ` [PING 6][PATCH " Kempke, Nils-Christian
2022-08-30 14:47             ` Kempke, Nils-Christian
2022-08-30 19:52 ` [PATCH " Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220610154500.374897-4-nils-christian.kempke@intel.com \
    --to=nils-christian.kempke@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).