public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Kempke, Nils-Christian" <nils-christian.kempke@intel.com>
To: Tom Tromey <tom@tromey.com>,
	Nils-Christian Kempke via Gdb-patches
	<gdb-patches@sourceware.org>
Subject: RE: [PATCH 3/4] testsuite, fortran: adapt tests for ifort's 'start' behavior
Date: Wed, 31 Aug 2022 09:32:08 +0000	[thread overview]
Message-ID: <CY4PR1101MB2071CC6F87CD788125390EA2B8789@CY4PR1101MB2071.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87czcha4s6.fsf@tromey.com>


Hi Tom,

Yes, that is true.. But I think that would also hold true for the 
gdb.fortran/vla-type.exp test then - where both, ifort and flang
skip all variable declaration statements, too.  Or do you see a
difference there?

I'll change this patch for both tests and remove the
get_compiler_info checks as well as the fortran_run_to_main call
for now.  Instead I'll directly call the 'runto'.

Thanks!

Nils

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Tuesday, August 30, 2022 9:52 PM
> To: Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> Subject: Re: [PATCH 3/4] testsuite, fortran: adapt tests for ifort's 'start'
> behavior
> 
> >>>>> Nils-Christian Kempke via Gdb-patches <gdb-
> patches@sourceware.org> writes:
> 
> > -gdb_continue_to_breakpoint "First Breakpoint"
> > +# Ifort is already at this line after runto_main.
> > +if { ![test_compiler_info {ifort-*} f90] } {
> > +    gdb_continue_to_breakpoint "First Breakpoint"
> > +}
> 
> I suspect that in this particular test it would be more robust to simply
> run to this first breakpoint and not try to run to main.  That way the
> test would be independent of where the compiler chooses to emit the
> 'main' entry point.
> 
> Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  reply	other threads:[~2022-08-31  9:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 15:44 [PATCH 0/4] Adapt Fortran testsuite for ifort Nils-Christian Kempke
2022-06-10 15:44 ` [PATCH 1/4] testsuite, fortran: make mixed-lang-stack less compiler dependent Nils-Christian Kempke
2022-06-10 15:44 ` [PATCH 2/4] testsuite, fortran: Remove self assignment non-statements Nils-Christian Kempke
2022-06-10 15:44 ` [PATCH 3/4] testsuite, fortran: adapt tests for ifort's 'start' behavior Nils-Christian Kempke
2022-08-30 19:51   ` Tom Tromey
2022-08-31  9:32     ` Kempke, Nils-Christian [this message]
2022-08-31 17:22       ` Tom Tromey
2022-06-10 15:45 ` [PATCH 4/4] testsuite, fortran: make kfail gfortran specific Nils-Christian Kempke
2022-07-04 15:59 ` [PING 2][PATCH 0/4] Adapt Fortran testsuite for ifort Kempke, Nils-Christian
2022-07-12 12:55   ` [PING 3][PATCH " Kempke, Nils-Christian
2022-07-27  5:14     ` [PING 4][PATCH " Kempke, Nils-Christian
2022-08-08 12:53       ` Kempke, Nils-Christian
2022-08-23 14:43         ` [PING 5][PATCH " Kempke, Nils-Christian
2022-08-30 14:47           ` [PING 6][PATCH " Kempke, Nils-Christian
2022-08-30 14:47             ` Kempke, Nils-Christian
2022-08-30 19:52 ` [PATCH " Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1101MB2071CC6F87CD788125390EA2B8789@CY4PR1101MB2071.namprd11.prod.outlook.com \
    --to=nils-christian.kempke@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).