From: Christopher Di Bella <cjdb@google.com>
To: gdb-patches@sourceware.org
Cc: manojgupta@google.com, Christopher Di Bella <cjdb@google.com>
Subject: [PATCH] [PATCH] [gdb] adds `<iterator>` to list of includes
Date: Tue, 28 Jun 2022 01:04:27 +0000 [thread overview]
Message-ID: <20220628010427.1856503-1-cjdb@google.com> (raw)
`std::back_inserter` is defined in `<iterator>`, which is currently
being transitively included by one of the other headers. This is causing
gdb to fail to build on certain platforms, which is fixed by explicitly
including it.
---
gdb/value.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/value.c b/gdb/value.c
index 022fca91a42..ba7ae1a0e18 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -40,6 +40,7 @@
#include "cp-abi.h"
#include "user-regs.h"
#include <algorithm>
+#include <iterator>
#include "completer.h"
#include "gdbsupport/selftest.h"
#include "gdbsupport/array-view.h"
--
2.37.0.rc0.161.g10f37bed90-goog
next reply other threads:[~2022-06-28 1:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 1:04 Christopher Di Bella [this message]
2022-07-01 13:45 ` Enze Li
2022-07-01 21:50 ` Christopher Di Bella
2022-07-09 4:30 ` Enze Li
2022-07-09 5:57 ` Manoj Gupta
2022-07-09 8:54 ` Enze Li
2022-07-10 18:52 ` Simon Marchi
2022-07-16 12:38 ` Enze Li
2022-07-09 9:10 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628010427.1856503-1-cjdb@google.com \
--to=cjdb@google.com \
--cc=gdb-patches@sourceware.org \
--cc=manojgupta@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).