Re: [PATCH] [PATCH] [gdb] adds `<iterator>` to list of includes

[Enze Li <enze.li@hotmail.com>]

On Tue, 2022-06-28 at 01:04 +0000, Christopher Di Bella via Gdb-patches
wrote:
> `std::back_inserter` is defined in `<iterator>`, which is currently
> being transitively included by one of the other headers. This is
> causing
> gdb to fail to build on certain platforms, which is fixed by
> explicitly
> including it.

Hi Christopher,

I didn't get your point through the commit message.  Can you clarify
exactly on which platforms, and what build error you encountered?  So
that I can reproduce the issue.

Thanks,
Enze


> ---
>  gdb/value.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gdb/value.c b/gdb/value.c
> index 022fca91a42..ba7ae1a0e18 100644
> --- a/gdb/value.c
> +++ b/gdb/value.c
> @@ -40,6 +40,7 @@
>  #include "cp-abi.h"
>  #include "user-regs.h"
>  #include <algorithm>
> +#include <iterator>
>  #include "completer.h"
>  #include "gdbsupport/selftest.h"
>  #include "gdbsupport/array-view.h"