From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 1/5] [COVER-LETTER, RFC] Fix some fsanitize=thread issues in gdb's cooked index
Date: Wed, 29 Jun 2022 17:29:10 +0200 [thread overview]
Message-ID: <20220629152914.13149-1-tdevries@suse.de> (raw)
This is an attempt at fixing some gdb thread sanitizer issues.
I used gcc 12 and -fsanitize=thread.
The patches address problems in the parallel reading of the cooked index.
There are a few problems remaining when testing:
- FAILs in test-case gdb.base/early-init-file.exp, submitted test-case patch
at https://sourceware.org/pipermail/gdb-patches/2022-June/190343.html
- we have a heap-use-after-free in gdb.dwarf2/dw2-icc-opaque.exp.
Not thread-related, filed at
https://sourceware.org/bugzilla/show_bug.cgi?id=29295.
- we run into timeouts in several test-cases:
- gdb.gdb/python-helper.exp
- gdb.multi/multi-target-thread-find.exp
- gdb.threads/break-while-running.exp
- gdb.threads/detach-step-over.exp
- gdb.threads/fork-thread-pending.exp
- gdb.threads/next-fork-other-thread.exp
- gdb.threads/pending-fork-event-detach.exp
- gdb.threads/wp-replication.exp
presumably due to sanitizer overhead.
- with tui tests, at the point of calling newterm we run into
"WARNING: ThreadSanitizer: unlock of an unlocked mutex (or by a wrong
thread)". This is reproducible in a standalone test-case calling newterm,
so not related to gdb. Affects:
- gdb.python/tui-window.exp
- gdb.tui/basic.exp
- gdb.tui/empty.exp
- gdb.tui/list.exp
- gdb.tui/new-layout.exp
- gdb.tui/regs.exp
- gdb.tui/tui-missing-src.exp
- gdb.tui/winheight.exp
- gdb.tui/winwidth.exp
- We run into 4 reported data races in gdb.base/gdb-sigterm.exp, filed at
https://sourceware.org/bugzilla/show_bug.cgi?id=29297.
---
gdb/COVER-LETTER | 0
1 file changed, 0 insertions(+), 0 deletions(-)
create mode 100644 gdb/COVER-LETTER
diff --git a/gdb/COVER-LETTER b/gdb/COVER-LETTER
new file mode 100644
index 00000000000..e69de29bb2d
base-commit: 9117c7b452ef76304f4394a97c887d0c4af439f5
--
2.35.3
next reply other threads:[~2022-06-29 15:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 15:29 Tom de Vries [this message]
2022-06-29 15:29 ` [PATCH 2/5] [gdb/symtab] Fix data race on per_cu->dwarf_version Tom de Vries
2022-07-01 11:16 ` Tom de Vries
2022-07-02 11:07 ` Tom de Vries
2022-07-04 18:51 ` Tom Tromey
2022-07-04 19:43 ` Tom de Vries
2022-07-04 19:53 ` Tom Tromey
2022-06-29 15:29 ` [PATCH 3/5] [gdb/symtab] Work around fsanitize=address false positive for per_cu->lang Tom de Vries
2022-06-29 17:38 ` Pedro Alves
2022-06-29 18:25 ` Pedro Alves
2022-06-29 18:28 ` Pedro Alves
2022-07-04 7:04 ` [PATCH 3/5] [gdb/symtab] Work around fsanitize=address false positive for per_ cu->lang Tom de Vries
2022-07-04 18:32 ` [PATCH 3/5] [gdb/symtab] Work around fsanitize=address false positive for per_cu->lang Tom Tromey
2022-07-04 19:45 ` Tom de Vries
2022-07-06 19:20 ` [PATCH] Introduce struct packed template, fix -fsanitize=thread for per_cu fields Pedro Alves
2022-07-07 10:18 ` Tom de Vries
2022-07-07 15:26 ` Pedro Alves
2022-07-08 14:54 ` Tom de Vries
2022-07-12 10:22 ` Tom de Vries
2022-06-29 15:29 ` [PATCH 4/5] [gdb/symtab] Work around fsanitize=address false positive for per_cu->unit_type Tom de Vries
2022-06-29 15:29 ` [PATCH 5/5] [gdb/symtab] Fix data race on per_cu->lang Tom de Vries
2022-07-04 18:30 ` Tom Tromey
2022-07-05 8:17 ` Tom de Vries
2022-07-05 15:19 ` Tom de Vries
2022-07-06 15:42 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629152914.13149-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).