public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@arm.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] [AArch64] Fix testcase compilation failure
Date: Tue, 5 Jul 2022 14:37:29 +0100	[thread overview]
Message-ID: <20220705133729.132750-1-luis.machado@arm.com> (raw)

Newer distros carry newer headers that contain MTE definitions.  Account
for that fact in the MTE testcases and define constants conditionally to
prevent compilation failures.
---
 gdb/testsuite/gdb.arch/aarch64-mte-gcore.c |  9 ++++++++-
 gdb/testsuite/gdb.arch/aarch64-mte.c       | 11 ++++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.arch/aarch64-mte-gcore.c b/gdb/testsuite/gdb.arch/aarch64-mte-gcore.c
index 6840acac33a..d19b5217e16 100644
--- a/gdb/testsuite/gdb.arch/aarch64-mte-gcore.c
+++ b/gdb/testsuite/gdb.arch/aarch64-mte-gcore.c
@@ -39,14 +39,21 @@
 #define PROT_MTE  0x20
 #endif
 
-/* From include/uapi/linux/prctl.h */
 #ifndef PR_SET_TAGGED_ADDR_CTRL
 #define PR_SET_TAGGED_ADDR_CTRL 55
 #define PR_GET_TAGGED_ADDR_CTRL 56
 #define PR_TAGGED_ADDR_ENABLE	(1UL << 0)
+#endif
+
+/* From include/uapi/linux/prctl.h */
+#ifndef PR_MTE_TCF_SHIFT
 #define PR_MTE_TCF_SHIFT	1
+#define PR_MTE_TCF_NONE		(0UL << PR_MTE_TCF_SHIFT)
 #define PR_MTE_TCF_SYNC		(1UL << PR_MTE_TCF_SHIFT)
+#define PR_MTE_TCF_ASYNC	(2UL << PR_MTE_TCF_SHIFT)
+#define PR_MTE_TCF_MASK		(3UL << PR_MTE_TCF_SHIFT)
 #define PR_MTE_TAG_SHIFT	3
+#define PR_MTE_TAG_MASK		(0xffffUL << PR_MTE_TAG_SHIFT)
 #endif
 
 void
diff --git a/gdb/testsuite/gdb.arch/aarch64-mte.c b/gdb/testsuite/gdb.arch/aarch64-mte.c
index bd7f1a6cf53..14057253035 100644
--- a/gdb/testsuite/gdb.arch/aarch64-mte.c
+++ b/gdb/testsuite/gdb.arch/aarch64-mte.c
@@ -30,15 +30,23 @@
 #include <sys/prctl.h>
 
 /* From arch/arm64/include/uapi/asm/hwcap.h */
+#ifndef HWCAP2_MTE
 #define HWCAP2_MTE              (1 << 18)
+#endif
 
 /* From arch/arm64/include/uapi/asm/mman.h */
+#ifndef PROT_MTE
 #define PROT_MTE  0x20
+#endif
 
-/* From include/uapi/linux/prctl.h */
+#ifndef PR_SET_TAGGED_ADDR_CTRL
 #define PR_SET_TAGGED_ADDR_CTRL 55
 #define PR_GET_TAGGED_ADDR_CTRL 56
 #define PR_TAGGED_ADDR_ENABLE	(1UL << 0)
+#endif
+
+/* From include/uapi/linux/prctl.h */
+#ifndef PR_MTE_TCF_SHIFT
 #define PR_MTE_TCF_SHIFT	1
 #define PR_MTE_TCF_NONE		(0UL << PR_MTE_TCF_SHIFT)
 #define PR_MTE_TCF_SYNC		(1UL << PR_MTE_TCF_SHIFT)
@@ -46,6 +54,7 @@
 #define PR_MTE_TCF_MASK		(3UL << PR_MTE_TCF_SHIFT)
 #define PR_MTE_TAG_SHIFT	3
 #define PR_MTE_TAG_MASK		(0xffffUL << PR_MTE_TAG_SHIFT)
+#endif
 
 void
 access_memory (unsigned char *tagged_ptr, unsigned char *untagged_ptr)
-- 
2.25.1


             reply	other threads:[~2022-07-05 13:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 13:37 Luis Machado [this message]
2022-07-05 14:49 ` Luis Machado
2022-07-11 11:58 ` [PATCH,v2] " Luis Machado
2022-07-19 13:37   ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220705133729.132750-1-luis.machado@arm.com \
    --to=luis.machado@arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).